Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxde-base/lxde-meta: Do not depend on lxshortcut #7706

Closed
wants to merge 1 commit into from
Closed

lxde-base/lxde-meta: Do not depend on lxshortcut #7706

wants to merge 1 commit into from

Conversation

charIes17
Copy link
Contributor

Bug: https://bugs.gentoo.org/651964

lxshortcut is obsolet upstream, so lxde-meta should not depend on it.
https://wiki.lxde.org/en/Status_of_LXDE_components

Package-Manager: Portage-2.3.24, Repoman-2.3.6

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: lxde-base/lxde-meta

lxde-base/lxde-meta: @gentoo/lxde

Bugs linked: 651964

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 30, 2018
@Moiman
Copy link
Contributor

Moiman commented Mar 30, 2018

Perhaps we should send last rites to lxde-base/lxshortcut. Also you could probably commit lxde-meta straight into stable.

@Moiman
Copy link
Contributor

Moiman commented Mar 30, 2018

You probably should do revision bump. But I'm not 100% sure.

@FuzzyGophers
Copy link
Contributor

This should be a revbump as it will ensure once the user upgrades that the old dependency is removed with --depclean.

@charIes17
lxde-base/lxde-meta: Do not depend on lxshortcut
a0bd86b 
Bug: https://bugs.gentoo.org/651964

lxshortcut is obsolet upstream, so lxde-meta should not depend on it.
https://wiki.lxde.org/en/Status_of_LXDE_components

Package-Manager: Portage-2.3.24, Repoman-2.3.6
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-04-01 03:01 UTC
Newest commit scanned: a0bd86b
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/c871195c3/output.html#media-libs/freeverb3
https://qa-reports.gentoo.org/output/gentoo-ci/c871195c3/output.html#net-fs/samba

@gentoo-bot gentoo-bot closed this in aced43e Apr 5, 2018
@charIes17 charIes17 deleted the lxde-meta branch April 9, 2018 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@charIes17 @gentoo-repo-qa-bot @Moiman @FuzzyGophers