Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-apps/onerng: New package #7714

Closed
wants to merge 10,000 commits into from
Closed

sys-apps/onerng: New package #7714

wants to merge 10,000 commits into from

Conversation

ConiKost
Copy link
Contributor

sys-apps/onerng: New package

Closes: https://bugs.gentoo.org/548526

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: sys-apps/onerng

sys-apps/onerng: @gentoo/proxy-maint (new package)

Bugs linked: 548526

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 30, 2018
@ConiKost ConiKost force-pushed the onerng branch 2 times, most recently from 70a09aa to e8f3796 Compare March 30, 2018 17:20
Zlogene
Zlogene suggested changes Apr 1, 2018
View reviewed changes
sys-apps/onerng/onerng-3.6.ebuild Outdated

src_install() {
# Install files
emake DESTDIR="${D}" install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not it default?

Copy link
Contributor Author

@ConiKost ConiKost Apr 1, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[EDIT]
Sorry, I misinterpreted this. You mean default as a "command", okay, that is better :) Pushed a new one.

sys-apps/onerng/onerng-3.6.ebuild Outdated
src_compile() {
# Run make
emake
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

@ConiKost ConiKost Apr 1, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[EDIT]
Forget what I said. I should use the right class python-r1. I am dropping this now. Pushed a new one.

sys-apps/onerng/onerng-3.6.ebuild Outdated

src_configure() {
# Run configure
econf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

@ConiKost ConiKost Apr 1, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[EDIT]
Forget what I said. I should use the right class python-r1. I am dropping this now. Pushed a new one.

sys-apps/onerng/onerng-3.6.ebuild Outdated
emake DESTDIR="${D}" install

# Install docs
local DOCS=( "AUTHORS" "ChangeLog" "INSTALL" "NEWS" "README" )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just default einstalldocs ?

Copy link
Contributor Author

@ConiKost ConiKost Apr 1, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, it only installs AUTHORS, ChangeLog and README. I wanted also to have INSTALL and NEWS for additional information. Or should I remove it?

@ConiKost ConiKost force-pushed the onerng branch 3 times, most recently from 5d34511 to 4f46a0d Compare April 1, 2018 20:08
@ConiKost ConiKost force-pushed the onerng branch 2 times, most recently from d50d692 to cc73e5a Compare April 28, 2018 09:18
Zlogene
Zlogene suggested changes Apr 29, 2018
View reviewed changes
sys-apps/onerng/onerng-3.6.ebuild Outdated

DOCS=( "AUTHORS" "ChangeLog" "INSTALL" "NEWS" "README" )

src_install() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is default you do not have to call for it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed.

mgorny
mgorny requested changes Jun 2, 2018
View reviewed changes
sys-apps/onerng/onerng-3.6.ebuild Outdated

EAPI=6

PYTHON_COMPAT=( python2_7 python3_{4,5} )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it work with Python 3.6? If you haven't tested yet, then please do.

Copy link
Contributor Author

@ConiKost ConiKost Jun 18, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but the dependencies do not all support python3.6, as dev-python/python-gnupg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.6 added, since dev-python/python-gnupg got now Python 3.6 support..

sys-apps/onerng/onerng-3.6.ebuild Outdated

S="${WORKDIR}/${PN}_${PV}"

DOCS=( "AUTHORS" "ChangeLog" "INSTALL" "NEWS" "README" )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you install INSTALL? Are people expected to install it manually after installing from ebuild? Otherwise, this look equivalent to automatic default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, removed it.

mgorny
mgorny reviewed Jun 19, 2018
View reviewed changes
sys-apps/onerng/onerng-3.6.ebuild Outdated
HOMEPAGE="https://www.onerng.info/"
SRC_URI="https://github.com/OneRNG/onerng.github.io/raw/master/sw/${PN}_${PV}.orig.tar.gz -> ${P}.tar.gz"

LICENSE="LGPL-3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the correct license.

https://github.com/OneRNG/firmware/blob/master/cdc.c#L6

Copy link
Contributor Author

@ConiKost ConiKost Jun 19, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a mess. The Homepage itself says LGPL-3 or GPL-3, the code says LGPL-2.1 or LGPL-3. I changed it now to the later one. I didn't choose LGPL-2.1+, since it's unclear, if newer LGPL versions will be accepted by him.

Sergei Trofimovich added 11 commits June 24, 2018 20:36
sys-apps/sed: stable 4.5 for ppc, bug #658388
1354234 
Bug: https://bugs.gentoo.org/658388
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
app-arch/tar: stable 1.30 for ppc, bug #658392
270e010 
Bug: https://bugs.gentoo.org/658392
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
sys-devel/gcc: stable 7.3.0-r3 for ppc, bug #658444
a26ea0b 
Bug: https://bugs.gentoo.org/658444
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
dev-ruby/http-cookie: stable 1.0.3 for ppc, bug #658782
2e37b76 
Bug: https://bugs.gentoo.org/658782
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
dev-libs/libnl: stable 3.4.0 for ppc, bug #658874
13128c5 
Bug: https://bugs.gentoo.org/658874
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
app-text/xapian-omega: stable 1.4.5 for ppc, bug #658876
0da940b 
Bug: https://bugs.gentoo.org/658876
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
dev-libs/xapian: stable 1.4.5 for ppc, bug #658876
778d936 
Bug: https://bugs.gentoo.org/658876
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
dev-util/dejagnu: stable 1.6 for ppc, bug #658894
28e73dd 
Bug: https://bugs.gentoo.org/658894
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
app-arch/rpm: stable 4.14.1 for ppc, bug #533740
d2ae29e 
Bug: https://bugs.gentoo.org/533740
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
dev-lang/vala: stable 0.34.16 for ppc, bug #652976
fca898f 
Bug: https://bugs.gentoo.org/652976
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
dev-perl/Devel-CheckLib: stable 1.110.0 for ppc, bug #657558
650bf37 
Bug: https://bugs.gentoo.org/657558
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc"
Sergei Trofimovich and others added 27 commits June 24, 2018 21:21
dev-perl/Sereal: stable 4.4.0 for ppc64, bug #657574
da42fe5 
Bug: https://bugs.gentoo.org/657574
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/Sereal-Decoder: stable 4.4.0 for ppc64, bug #657574
9eab345 
Bug: https://bugs.gentoo.org/657574
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/Sereal-Encoder: stable 4.4.0 for ppc64, bug #657574
0dcb62d 
Bug: https://bugs.gentoo.org/657574
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/App-pwhich: stable 1.140.0 for ppc64, bug #657592
79191a6 
Bug: https://bugs.gentoo.org/657592
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
app-crypt/gnupg: stable 2.2.8 for ppc64, bug #657596
1281b81 
Bug: https://bugs.gentoo.org/657596
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/Apache-LogFormat-Compiler: stable 0.350.0 for ppc64, bug #65…
18bc2a8 
…7690

Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/Authen-Simple: stable 0.500.0 for ppc64, bug #657690
3388a94 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/Cookie-Baker: stable 0.80.0 for ppc64, bug #657690
b3dec66 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/File-ShareDir: stable 1.104.0 for ppc64, bug #657690
5c1995d 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/HTTP-Entity-Parser: stable 0.200.0 for ppc64, bug #657690
b20e54f 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/JSON: stable 2.940.0 for ppc64, bug #657690
62ba3f8 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/JSON-MaybeXS: stable 1.3.9 for ppc64, bug #657690
67b2c22 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/JSON-RPC: stable 1.60.0 for ppc64, bug #657690
983d140 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/JSON-XS: stable 3.40.0 for ppc64, bug #657690
3b1c1b2 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/POSIX-strftime-Compiler: stable 0.420.0 for ppc64, bug #657690
a1ab8d0 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/Plack: stable 1.4.400 for ppc64, bug #657690
3b6c8b0 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/Types-Serialiser: stable 1.0.0-r1 for ppc64, bug #657690
968c1ff 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-perl/WWW-Form-UrlEncoded: stable 0.240.0 for ppc64, bug #657690
ed9e074 
Bug: https://bugs.gentoo.org/657690
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --include-arches="ppc64"
dev-libs/libmaxminddb: Old.
9fcd87a 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
app-admin/fam: Stable for HPPA too.
923b65a 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --ignore-arches
dev-libs/glib: Stable for HPPA too.
756c422 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --ignore-arches
@a17r
media-gfx/pencil: 0.6.1.1 version bump
1bcbc79 
Punt unused dependency.

Closes: https://bugs.gentoo.org/658974
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@a17r
media-gfx/pencil: Drop old
f53d92e 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@a17r
x11-themes/qtcurve: Drop old Qt4-based
d904a59 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@ConiKost @mgorny
net-misc/networkmanager-strongswan: New package
ad8a3f5 
Closes: https://bugs.gentoo.org/571234
Closes: gentoo#7663
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@sarnold
app-admin/logrotate: fix patch-not-being-applied error on 3.14
d03c93b 
* eapply_user is not currently a substitute for default

Package-Manager: Portage-2.3.40, Repoman-2.3.9
@ConiKost
sys-apps/onerng: New package
02546e9 
Closes: https://bugs.gentoo.org/548526
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-06-25 14:15 UTC
Newest commit scanned: 02546e9
Status: ✅ good

No issues found

@ConiKost ConiKost mentioned this pull request Jul 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny requested changes

@Zlogene Zlogene Zlogene requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
8 participants
@ConiKost @gentoo-repo-qa-bot @mgorny @Zlogene @gentoogang @pacho2 @a17r @sarnold