x11-libs/libdlo: New package #7844
Conversation
|
Pull Request assignment Areas affected: ebuilds x11-libs/libdlo: @gentoo/proxy-maint (new package) Bugs linked: 652702 In order to force reassignment and/or bug reference scan, please append |
gentoo-repo-qa-bot
added
new package
|
@a17r Would you also have a look here? It's a needed dependency for dev-libs/serdisplib. |
There was a problem hiding this comment.
Package installs /usr/bin/test1 - that's unfortunately not a very distinctive filename and should be changed to e.g. ${PN}-test (it may make sense to check how other distros do it). If this is just an example or tool it could also be made optional. If this is just for testing the library this should not be installed at all. By the looks of it, the latter seems to be the case.
Unnecessary /usr/lib64/libdlo.la should be removed via the usual find "${D}" -name '*.la' -delete || die in src_install.
Don't install /usr/lib64/libdlo.a unless USE=static-libs was set.
x11-libs/libdlo/metadata.xml
Outdated
| It's still very much under development, but it's possible to write custom applications | ||
| to it today (or to libdlo user mode library itself, bypassing udlfb). | ||
| And it's also possible to configure X and standard X applications to run on udlfb | ||
| but that part is still very distro dependent today. Most people in the DisplayLink |
There was a problem hiding this comment.
That description seems to be overly long, even if it is called longdescription. At least the last two sentences seem superfluous. And what about the kernel number reference relative to 'to date' - it could be a distraction or make it appear this being a very old (?) package contrary to being 'still very much under development'.
There was a problem hiding this comment.
I've changed the description, which shoud now sound better.
From what I understand, this tool can be used to test your own displaylink device. I've made an use flag "test-program" for this, on which the installation depends and renamed it to displaylink-test.
Added to the eBuild.
Fixed, it depends now on IUSE="static-libs". |
x11-libs/libdlo/libdlo-0.1.2.ebuild
Outdated
| # Only build the Displaylink test program, if a user want's it. | ||
| # If a user want's it, rename test1 to displaylink-test. | ||
| if ! use test-program; then | ||
| sed -i -e '/test\/Makefile/d' configure.ac || die |
There was a problem hiding this comment.
I need to put the obligatory statement here that an (unconditional) patch is usually the preferred method. That said, you can use one sed per file here instead of multiple calls, just use -e for each change.
There was a problem hiding this comment.
I've done a patch now :)
x11-libs/libdlo/libdlo-0.1.2.ebuild
Outdated
| # archiver requires 'AM_PROG_AR' in 'configure.ac'. | ||
| sed -i -e '/AC_PROG_CC/a AM_PROG_AR' configure.ac || die | ||
|
|
||
| # Only build the Displaylink test program, if a user want's it. |
There was a problem hiding this comment.
no apostrophe in wants, same on next line ;)
x11-libs/libdlo/libdlo-0.1.2.ebuild
Outdated
| sed -i -e '/test\/images.*/d' Makefile.am || die | ||
| sed -i -e '/TESTS .*/d' Makefile.am || die | ||
| else | ||
| sed -i -e 's/TESTS .*/TESTS = test\/displaylink-test/' Makefile.am || die |
There was a problem hiding this comment.
rather than all that, you could just mv the binary during src_install. :)
There was a problem hiding this comment.
Fine for me. Just did it this way, as someone told me, that I should avoid using things like mv in src_install and patch the build system.
There was a problem hiding this comment.
ah, that depends, but this case is trivial. again, a build system patch that you can take upstream is always preferred, so that these workarounds can at some point be dropped. It should not take much convincing upstream that test1 is a bad name.
There was a problem hiding this comment.
Okay, changed now in newest version.
Closes: https://bugs.gentoo.org/652702 Package-Manager: Portage-2.3.24, Repoman-2.3.6
|
Pull request CI report Report generated at: 2018-04-23 22:19 UTC No issues found Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation. This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage. |
x11-libs/libdlo: New package
Closes: https://bugs.gentoo.org/652702