sci-electronics/xcircuit: version bump to 3.9.73 #7945

ktrace · 2018-04-11T21:56:50Z

Closes: https://bugs.gentoo.org/652984
Closes: #7945

Package-Manager: Portage-2.3.24, Repoman-2.3.6

Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

a17r · 2018-04-11T22:20:20Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+src_prepare() {
+	mv configure.{in,ac} || die
+	eautoreconf
+	default


default should be first in src_prepare()

a17r · 2018-04-11T22:20:25Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+
+src_prepare() {
+	mv configure.{in,ac} || die
+	eautoreconf


did you check if this is actually required? if not, you can also drop autotools.eclass

autoreconf really needed

a17r · 2018-04-11T22:22:23Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+}
+
+src_configure() {
+	local myeconfargs=(


you define this, then throw it away. myeconfargs is no magic variable, you'll have to run econf "${myeconfargs[@]}" instead of default below.

a17r · 2018-04-11T22:23:24Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+	app-text/ghostscript-gpl
+	dev-lang/tk:0
+	media-libs/fontconfig:1.0
+	sys-libs/zlib


missing :=

a17r · 2018-04-11T22:24:31Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+
+DEPEND="
+	app-text/ghostscript-gpl
+	dev-lang/tk:0


should be :0=

a17r · 2018-04-11T22:25:16Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+	x11-libs/libX11
+	x11-libs/libXt
+	x11-libs/libXpm
+	x11-libs/libSM


this and line below: please keep deps sorted

a17r · 2018-04-11T22:26:02Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+
+src_configure() {
+	local myeconfargs=(
+		--disable-dependency-tracking


should not have to add this, it is default since EAPI-4.

a17r · 2018-04-11T22:26:27Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+
+EAPI=6
+
+inherit autotools multilib


multilib is nowhere used in this ebuild

Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

a17r · 2018-04-15T08:53:33Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+	app-text/ghostscript-gpl:0=
+	media-libs/fontconfig:1.0=
+	sys-libs/zlib:0=
+	tcl? (


optional DEPENDs below unconditional please

a17r · 2018-04-15T08:56:26Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+
+src_configure() {
+	econf \
+	   $( use_with tcl ) \


Please fix the messy whitespace and indentation situation here. Tabs for indendation, indent once for each line below econf...
This piece of code was fine before, you would not have needed to drop the myeconfargs var after I told you how to use it.

a17r · 2018-04-15T08:57:40Z

sci-electronics/xcircuit/xcircuit-3.9.72.ebuild

+IUSE="tcl"
+
+DEPEND="
+	app-text/ghostscript-gpl:0=


This and each line below: My last review gave you precise slot op information. Not for all DEPENDs.

Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

- version bump - switch to EAPI=6 - add USE="tcl" and fix tcl support Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

gentoo-repo-qa-bot · 2018-04-24T14:55:09Z

Pull Request assignment

Areas affected: ebuilds
Packages affected: sci-electronics/xcircuit

sci-electronics/xcircuit: @gentoo/sci-electronics

Bugs linked: 652984

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

SoapGentoo · 2018-04-25T21:41:02Z

sci-electronics/xcircuit/xcircuit-3.9.73.ebuild

+		--with-cairo
+		--with-ngspice
+		$(use_with tcl)
+		$(use_with tcl tcllibs "/usr/$(get_libdir)")


$(use_with tcl tcllibs "${EPREFIX}/usr/$(get_libdir)")

- version bump - switch to EAPI=6 - add USE="tcl" and fix tcl support Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

gentoo-repo-qa-bot · 2018-04-26T14:43:51Z

Pull request CI report

Report generated at: 2018-04-26 14:43 UTC
Newest commit scanned: 8dfb7e0
Status: ✅ good

No issues found

Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Apr 11, 2018

ktrace force-pushed the xcircuit branch from 643ba3c to c2175d0 Compare April 11, 2018 22:12

ktrace pushed a commit to ktrace/gentoo that referenced this pull request Apr 11, 2018

sci-electronics/xcircuit: version bump to 3.9.72

c2175d0

Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

ktrace force-pushed the xcircuit branch from c2175d0 to 24f5481 Compare April 11, 2018 22:15

ktrace pushed a commit to ktrace/gentoo that referenced this pull request Apr 11, 2018

sci-electronics/xcircuit: version bump to 3.9.72

24f5481

Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

a17r suggested changes Apr 11, 2018

View reviewed changes

ktrace force-pushed the xcircuit branch from 24f5481 to 2188cba Compare April 14, 2018 20:22

ktrace pushed a commit to ktrace/gentoo that referenced this pull request Apr 14, 2018

sci-electronics/xcircuit: version bump to 3.9.72

2188cba

Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

a17r suggested changes Apr 15, 2018

View reviewed changes

ktrace force-pushed the xcircuit branch from 2188cba to adb25ad Compare April 15, 2018 09:51

ktrace pushed a commit to ktrace/gentoo that referenced this pull request Apr 15, 2018

sci-electronics/xcircuit: version bump to 3.9.72

adb25ad

Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

ktrace force-pushed the xcircuit branch from c170874 to 3782e45 Compare April 15, 2018 13:32

ktrace pushed a commit to ktrace/gentoo that referenced this pull request Apr 15, 2018

sci-electronics/xcircuit: version bump to 3.9.72

3782e45

Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

ktrace changed the title ~~sci-electronics/xcircuit: version bump to 3.9.72~~ sci-electronics/xcircuit: version bump to 3.9.72 [please reassign] Apr 15, 2018

gentoo-repo-qa-bot changed the title ~~sci-electronics/xcircuit: version bump to 3.9.72 [please reassign]~~ sci-electronics/xcircuit: version bump to 3.9.72 Apr 15, 2018

ktrace force-pushed the xcircuit branch from 3782e45 to de9a17a Compare April 23, 2018 14:22

ktrace pushed a commit to ktrace/gentoo that referenced this pull request Apr 23, 2018

sci-electronics/xcircuit: version bump to 3.9.72

de9a17a

Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

ktrace force-pushed the xcircuit branch from de9a17a to 5ee31d3 Compare April 24, 2018 14:41

ktrace changed the title ~~sci-electronics/xcircuit: version bump to 3.9.72~~ sci-electronics/xcircuit: version bump to 3.9.73 [please reassign] Apr 24, 2018

gentoo-repo-qa-bot changed the title ~~sci-electronics/xcircuit: version bump to 3.9.73 [please reassign]~~ sci-electronics/xcircuit: version bump to 3.9.73 Apr 24, 2018

gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 24, 2018

gentoo-repo-qa-bot added the bug linked Bug/Closes found in footer, and cross-linked with the PR. label Apr 24, 2018

SoapGentoo suggested changes Apr 25, 2018

View reviewed changes

ktrace force-pushed the xcircuit branch from 5ee31d3 to fb011a3 Compare April 25, 2018 21:57

a17r approved these changes Apr 25, 2018

View reviewed changes

SoapGentoo approved these changes Apr 25, 2018

View reviewed changes

sci-electronics/xcircuit: version bump to 3.9.73

8dfb7e0

- version bump - switch to EAPI=6 - add USE="tcl" and fix tcl support Closes: https://bugs.gentoo.org/652984 Closes: gentoo#7945 Package-Manager: Portage-2.3.24, Repoman-2.3.6

ktrace force-pushed the xcircuit branch from fb011a3 to 8dfb7e0 Compare April 26, 2018 11:42

gentoo-bot closed this in 8ddd50d Apr 27, 2018

ktrace deleted the xcircuit branch June 5, 2018 11:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sci-electronics/xcircuit: version bump to 3.9.73 #7945

sci-electronics/xcircuit: version bump to 3.9.73 #7945

ktrace commented Apr 11, 2018 •

edited

a17r Apr 11, 2018

a17r Apr 11, 2018

ktrace Apr 11, 2018

a17r Apr 11, 2018

a17r Apr 11, 2018

a17r Apr 11, 2018

a17r Apr 11, 2018

a17r Apr 11, 2018

a17r Apr 11, 2018

a17r Apr 15, 2018

a17r Apr 15, 2018

a17r Apr 15, 2018

gentoo-repo-qa-bot commented Apr 24, 2018

SoapGentoo Apr 25, 2018

gentoo-repo-qa-bot commented Apr 26, 2018

sci-electronics/xcircuit: version bump to 3.9.73 #7945

sci-electronics/xcircuit: version bump to 3.9.73 #7945

Conversation

ktrace commented Apr 11, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Apr 24, 2018

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Apr 26, 2018

ktrace commented Apr 11, 2018 •

edited