dev-libs/nmeap: New package #7989
Conversation
|
Pull Request assignment Areas affected: ebuilds dev-libs/nmeap: @gentoo/proxy-maint (new package) Bugs linked: 653150 In order to force reassignment and/or bug reference scan, please append Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation. This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage. |
gentoo-repo-qa-bot
added
new package
|
@a17r Since you were so kind to review my LCD4Linux and Deps stuff, could you here also have a look? This is also a new needed dependency for LCD4Linux. |
ConiKost
force-pushed
the
nmeap
branch
2 times, most recently
from
23c0351
to
a7e65ee
Compare
dev-libs/nmeap/nmeap-0.3.ebuild
Outdated
| done | ||
| fi | ||
|
|
||
| # Install docs |
There was a problem hiding this comment.
Removed and pushed.
dev-libs/nmeap/nmeap-0.3.ebuild
Outdated
| insinto /usr/$(get_libdir) | ||
| doins lib/libnmeap.a | ||
|
|
||
| # Install test programs |
There was a problem hiding this comment.
Removed and pushed.
dev-libs/nmeap/nmeap-0.3.ebuild
Outdated
| doins inc/nmeap.h inc/nmeap_def.h | ||
|
|
||
| # Install static lib archive | ||
| insinto /usr/$(get_libdir) |
There was a problem hiding this comment.
does not it support shared libs?
There was a problem hiding this comment.
Yes, this is correct. It don't builds any *.so, only the *.a.
dev-libs/nmeap/nmeap-0.3.ebuild
Outdated
| } | ||
|
|
||
| src_install() { | ||
| # Install header files |
There was a problem hiding this comment.
Removed and pushed.
ConiKost
force-pushed
the
nmeap
branch
4 times, most recently
from
fb2590b
to
a7d5f82
Compare
dev-libs/nmeap/nmeap-0.3.ebuild
Outdated
| doins inc/nmeap.h inc/nmeap_def.h | ||
|
|
||
| insinto /usr/$(get_libdir) | ||
| doins lib/libnmeap.a |
There was a problem hiding this comment.
please point dolib.a without manual defenitions here
There was a problem hiding this comment.
Done. Also did doheader for above.
ConiKost
force-pushed
the
nmeap
branch
3 times, most recently
from
d7f514b
to
a553014
Compare
ConiKost
force-pushed
the
nmeap
branch
3 times, most recently
from
271661e
to
94d088a
Compare
dev-libs/nmeap/nmeap-0.3.ebuild
Outdated
|
|
||
| if use doc; then | ||
| local HTML_DOCS=( "doc/tutorial.html" "doc/html" ) | ||
| doxygen Doxyfile || die |
There was a problem hiding this comment.
Makes more sense, changed it.
dev-libs/nmeap/nmeap-0.3.ebuild
Outdated
| doxygen Doxyfile || die | ||
| fi | ||
|
|
||
| if use test-programs; then |
There was a problem hiding this comment.
Do you install any documentation that explains the purpose of those programs? If not, then installing programs called nmeap-testN looks like a useless idea.
There was a problem hiding this comment.
They generate different nmea output, if someone needs fake gps. But for my understanding, this is only for testing purposes. What do you think, remove it? For LCD4Linux, for this dependency it is, it's not needed.
There was a problem hiding this comment.
I would not install something that's not documented and has no clear use for the user.
There was a problem hiding this comment.
Ok, fine for me. I dropped it now.
ConiKost
force-pushed
the
nmeap
branch
3 times, most recently
from
fbf9566
to
3303bbc
Compare
There was a problem hiding this comment.
make[1]: Entering directory '/tmp/portage/dev-libs/nmeap-0.3/work/nmeap-0.3/src'
gcc -c -march=k8-sse3 -mcx16 -msahf --param l1-cache-size=64 --param l1-cache-line-size=64 --param l2-cache-size=512 -O2 -pipe -frecord-gcc-switches -I /tmp/portage/dev-libs/nmeap-0.3/work/nmeap-0.3/inc -DNDEBUG -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu /tmp/portage/dev-libs/nmeap-0.3/work/nmeap-0.3/src/nmeap01.c -o nmeap01.o
rm -f /tmp/portage/dev-libs/nmeap-0.3/work/nmeap-0.3/lib/libnmeap.a
ar -q /tmp/portage/dev-libs/nmeap-0.3/work/nmeap-0.3/lib/libnmeap.a nmeap01.o
ar: creating /tmp/portage/dev-libs/nmeap-0.3/work/nmeap-0.3/lib/libnmeap.a
CC and AR are not respected.
|
Fixed. |
dev-libs/nmeap/nmeap-0.3.ebuild
Outdated
| default | ||
|
|
||
| # Repsect users CFLAGS and LDFLAGS for the static lib archive | ||
| sed -i -e 's/CFLAGS =/CFLAGS +=/' -e 's/-g -O0 -Werror -Wall/$(LDFLAGS)/' src/Makefile || die |
There was a problem hiding this comment.
LDFLAGS are not correct here since you aren't linking anything.
There was a problem hiding this comment.
Okay, I thought, even when a static archive, it should be set. Removed now.
Needed by: https://bugs.gentoo.org/652706 Closes: https://bugs.gentoo.org/653150 Package-Manager: Portage-2.3.40, Repoman-2.3.9
|
Pull request CI report Report generated at: 2018-06-20 08:14 UTC No issues found |
dev-libs/nmeap: New package
Needed by: https://bugs.gentoo.org/652706
Closes: https://bugs.gentoo.org/653150
Package-Manager: Portage-2.3.30, Repoman-2.3.9