Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-video/openshot: add dev-python/requests to RDEPEND #8052

Closed
wants to merge 1 commit into from
Closed

media-video/openshot: add dev-python/requests to RDEPEND #8052

wants to merge 1 commit into from

Conversation

juippis
Copy link
Member

@juippis juippis commented Apr 18, 2018

  • added dev-python/requests to RDEPEND
  • added https:// to HOMEPAGE
  • added ~ keywords and made a revbump
  • sorted deps alphabetically

Fast fix for a bug. Repomanned and emerged succesfully.

--- openshot-2.4.0.ebuild	2018-04-05 09:45:31.044726504 +0300
+++ openshot-2.4.0-r1.ebuild	2018-04-18 10:23:55.522500517 +0300
@@ -13,20 +13,22 @@
 MY_P="${MY_PN}-${PV}"
 
 DESCRIPTION="Free, open-source, non-linear video editor to create and edit videos and movies"
-HOMEPAGE="http://www.openshot.org/ https://launchpad.net/openshot"
+HOMEPAGE="https://www.openshot.org/ https://launchpad.net/openshot"
 SRC_URI="https://launchpad.net/${PN}/$(get_version_component_range 1-2)/${PV}/+download/${MY_P}.tar.gz"
 
 LICENSE="GPL-3+"
 SLOT="1"
-KEYWORDS="amd64 x86"
+KEYWORDS="~amd64 ~x86"
 
 RDEPEND="
-	dev-python/PyQt5[svg,webkit,${PYTHON_USEDEP}]
-	>=media-libs/libopenshot-0.1.8[python,${PYTHON_USEDEP}]
 	dev-python/httplib2[${PYTHON_USEDEP}]
+	dev-python/PyQt5[${PYTHON_USEDEP},svg,webkit]
 	dev-python/pyzmq[${PYTHON_USEDEP}]
+	dev-python/requests[${PYTHON_USEDEP}]
+	>=media-libs/libopenshot-0.1.8[python,${PYTHON_USEDEP}]
 "
 DEPEND="
+	${PYTHON_DEPS}
 	dev-python/setuptools[${PYTHON_USEDEP}]
 "

Closes: https://bugs.gentoo.org/637448
Package-Manager: Portage[mgorny]-2.3.26.1

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: media-video/openshot

media-video/openshot: @gentoo/proxy-maint (maintainer needed)

Bugs linked: 637448

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Apr 18, 2018
mgorny
mgorny requested changes Apr 29, 2018
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. However, given this is a clear dependency fix with no other changes, you can git mv the original ebuild to new revision, keeping the stable keywords (given that repoman full -d is happy with the deps).

media-video/openshot/openshot-2.4.0-r1.ebuild Outdated
>=media-libs/libopenshot-0.1.8[python,${PYTHON_USEDEP}]
"
DEPEND="
${PYTHON_DEPS}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distutils-r1 takes care of PYTHON_DEPS for you. Also, it should've been RDEPEND ;-).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, lets try that again. Im rebasing and hoping it goes well...

--- /usr/portage/media-video/openshot/openshot-2.4.0.ebuild	2018-03-10 09:08:28.641702227 +0200
+++ openshot-2.4.0-r1.ebuild	2018-04-29 11:44:28.448921711 +0300
@@ -13,7 +13,7 @@
 MY_P="${MY_PN}-${PV}"
 
 DESCRIPTION="Free, open-source, non-linear video editor to create and edit videos and movies"
-HOMEPAGE="http://www.openshot.org/ https://launchpad.net/openshot"
+HOMEPAGE="https://www.openshot.org/ https://launchpad.net/openshot"
 SRC_URI="https://launchpad.net/${PN}/$(get_version_component_range 1-2)/${PV}/+download/${MY_P}.tar.gz"
 
 LICENSE="GPL-3+"
@@ -21,10 +21,11 @@
 KEYWORDS="amd64 x86"
 
 RDEPEND="
-	dev-python/PyQt5[svg,webkit,${PYTHON_USEDEP}]
-	>=media-libs/libopenshot-0.1.8[python,${PYTHON_USEDEP}]
 	dev-python/httplib2[${PYTHON_USEDEP}]
+	dev-python/PyQt5[${PYTHON_USEDEP},svg,webkit]
 	dev-python/pyzmq[${PYTHON_USEDEP}]
+	dev-python/requests[${PYTHON_USEDEP}]
+	>=media-libs/libopenshot-0.1.8[python,${PYTHON_USEDEP}]
 "
 DEPEND="
 	dev-python/setuptools[${PYTHON_USEDEP}]
~/git/gentoo/media-video/openshot $ repoman full -dx .

RepoMan scours the neighborhood...
RepoMan sez: "If everyone were like you, I'd be out of business!"

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-04-30 00:27 UTC
Newest commit scanned: 9f97515
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#app-admin/rsyslog
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#app-doc/edox-data
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#dev-libs/efl
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#dev-python/python-efl
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#media-libs/elementary
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#media-libs/freeverb3
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#media-libs/imlib2
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#media-plugins/emotion_generic_players
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#media-plugins/evas_generic_loaders
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#media-plugins/imlib2_loaders
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#net-fs/samba
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#x11-misc/e16keyedit
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#x11-misc/e16menuedit2
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#x11-plugins/epplets
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#x11-terms/terminology
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#x11-themes/ethemes
https://qa-reports.gentoo.org/output/gentoo-ci/c424dcff9/output.html#x11-wm/enlightenment

Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

@mgorny
Copy link
Member

mgorny commented May 1, 2018

Thanks! I'll merge it in a minute ;-).

@gentoo-bot gentoo-bot closed this in c049a24 May 1, 2018
@juippis juippis deleted the media-video.openshot.add-requests-to-rdepend branch May 21, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
3 participants
@juippis @gentoo-repo-qa-bot @mgorny