media-libs/ampache_browser: bump to 1.0.1 #8059
Conversation
|
Pull Request assignment Areas affected: ebuilds media-libs/ampache_browser: @openhs, @gentoo/proxy-maint No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment. In order to force reassignment and/or bug reference scan, please append Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation. This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage. |
gentoo-repo-qa-bot
added
self-maintained
|
|
||
| EAPI=6 | ||
|
|
||
| CMAKE_MIN_VERSION=3.0 |
There was a problem hiding this comment.
this is not necessary, cmake-utils.eclass is already setting this to 3.9.6.
| LICENSE="GPL-3" | ||
| SLOT="0" | ||
| KEYWORDS="~amd64 ~x86" | ||
| IUSE="nls debug" |
|
Can you squash both commits into one and force-push over this branch? |
|
Sure I can. But I am really confused when I should use separate commits and when not. Here, I followed https://wiki.gentoo.org/wiki/Gentoo_GitHub#Commit_format where in section "Separate (or "atomic") commits" are described three changes to be committed separately. |
|
Here you are bumping a version, it is fine to fix that trivial stuff at the same time. It is that trivial that no one will ever be interested in reverting it in the future. ;) It is not like you drop a version or change metadata.xml at the same time, which are mentioned as examples in that paragraph. |
|
Pull request CI report Report generated at: 2018-04-23 20:48 UTC Issues already there before the PR (double-check them): Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation. This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage. |
No description provided.