Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-benchmarks/cpuburn: Add arm support and fix QA warnings #8274

Closed
wants to merge 1 commit into from

Conversation

ConiKost
Copy link
Contributor

@ConiKost ConiKost commented May 5, 2018

Changes:

  1. Bump to EAPI=6
  2. Add support for ARM
  3. Fix QA warnings
  • I just set the QA_* variables, as I think, it can't be better done. Compiling with GCC, it does not seem to use CFLAGS, when only compiling assembler. Also, for Textrels, it says ELF has TEXTREL markings but doesnt appear to have any real TEXTREL's !? So could be a false positive?

Closes: https://bugs.gentoo.org/show_bug.cgi?id=650058
Closes: https://bugs.gentoo.org/show_bug.cgi?id=654966
Package-Manager: Portage-2.3.35, Repoman-2.3.9

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: app-benchmarks/cpuburn

app-benchmarks/cpuburn: @gentoo/proxy-maint (maintainer needed)

Bugs linked: 650058, 654966

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.


Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 5, 2018

src_compile() {
if use arm; then
cd "${S}"/ARM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| die

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to add the die. Saw it today early, but forgot to say here, that I will fix it. Done now.


EAPI=6

inherit eutils
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

@ConiKost ConiKost May 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to delete after switch to newer EAPI. Saw it today early, but forgot to say here, that I will fix it. Done now.

@ConiKost ConiKost force-pushed the cpuburn branch 2 times, most recently from a681ee2 to eb50dd3 Compare May 11, 2018 15:19
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-05-12 01:59 UTC
Newest commit scanned: 04cc558
Status: ✅ good

No issues found


Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's good enough.

@gentoo-bot gentoo-bot closed this in 8588318 Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
4 participants