Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/pyftpdlib: bump to 1.5.4, drop unsupported pypy{,3} #8363

Closed
wants to merge 1 commit into from

Conversation

sbraz
Copy link
Member

@sbraz sbraz commented May 12, 2018

I had to pass --force because pysendfile isn't keyworded on some archs. I dropped pypy and pypy3 because tests fail on these and upstream doesn't officially support them.
giampaolo/pyftpdlib@release-1.5.3...release-1.5.4

Some of the dependencies are now required to run the tests:

--- pyftpdlib-1.5.3.ebuild      2018-04-28 18:04:14.483510669 +0200
+++ pyftpdlib-1.5.4.ebuild      2018-05-12 16:24:25.976209443 +0200
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2

 EAPI=6
-PYTHON_COMPAT=( python{2_7,3_{4,5,6}} pypy{,3} )
+PYTHON_COMPAT=( python{2_7,3_{4,5,6}} )
 PYTHON_REQ_USE="ssl(+)"

 inherit distutils-r1
@@ -24,6 +24,9 @@
        test? (
                ${RDEPEND}
                dev-python/mock[${PYTHON_USEDEP}]
+               dev-python/psutil[${PYTHON_USEDEP}]
+               dev-python/pyopenssl[${PYTHON_USEDEP}]
+               dev-python/pysendfile[${PYTHON_USEDEP}]
        )
 "

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-python/pyftpdlib

dev-python/pyftpdlib: @gentoo/python

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.


Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 12, 2018
@mgorny
Copy link
Member

mgorny commented May 12, 2018

  1. You need to drop keywords, and open a rekeywording bug once this is merged.
  2. Did you check whether any revdeps need pypy?

@sbraz
Copy link
Member Author

sbraz commented May 12, 2018

Do we really need all arches to support this test dependency?
The only revdep is dev-vcs/bzr which only supports py2.7.

@mgorny
Copy link
Member

mgorny commented May 13, 2018

We let the arch teams decide if they want to rekeyword it or not.

@sbraz
Copy link
Member Author

sbraz commented May 16, 2018

@mgorny repushed without the unsupported arches:

  KEYWORDS.dropped              1
   dev-python/pyftpdlib/pyftpdlib-1.5.4.ebuild: alpha amd64-fbsd arm arm64 ia64 ppc ppc64

@sbraz
Copy link
Member Author

sbraz commented May 26, 2018

Just noticed I forgot to DEPEND on sphinx, I'll repush with the fixed ebuild.

Add missing sphinx dependency for doc build, disable intersphinx.

Package-Manager: Portage-2.3.31, Repoman-2.3.9
RepoMan-Options: --force
@sbraz
Copy link
Member Author

sbraz commented May 27, 2018

Repushed with the proper sphinx deps. This should be good to go.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-05-27 13:17 UTC
Newest commit scanned: 5f5c912
Status: ✅ good

No issues found

@sbraz sbraz deleted the pyftpdlib branch June 26, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants