media-libs/aribb24-1.0.3: new package #8438
Conversation
aribb24 is a library for decoding ARIB STD-B24 subtitles. Closes: https://bugs.gentoo.org/655910 Package-Manager: Portage-2.3.36, Repoman-2.3.9
|
Pull Request assignment Areas affected: ebuilds media-libs/aribb24: @gentoo/proxy-maint (new package) Bugs linked: 655910 In order to force reassignment and/or bug reference scan, please append Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation. This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage. |
gentoo-repo-qa-bot
added
new package
|
Pull request CI report Report generated at: 2018-05-16 20:03 UTC No issues found Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation. This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage. |
|
Can I get a review for this PR? I'm happy to proxy-maintain the package :-) This will be a dependency for media-video/vlc (VLC has support for this library/format but Gentoo is lacking it so it is missing). I'll submit a PR to add the required USE flag to VLC once this is in. |
| HOMEPAGE="https://github.com/nkoriyama/aribb24" | ||
| SRC_URI="https://github.com/nkoriyama/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz" | ||
|
|
||
| LICENSE="LGPL-3" |
There was a problem hiding this comment.
AFAICS most of the source files specify LGPL-2.1+ in the heading. Could you verify this? If all sources use LGPL-2.1+, then that is the correct license
There was a problem hiding this comment.
The files that do have headers say LGPL-2.1+, but I'm reluctant to claim that as the license when the main COPYING file is LGPL-3 (and some files have no license header, so the COPYING file should apply as a whole).
There was a problem hiding this comment.
Are those files with no license header sources or otherwise installed?
There was a problem hiding this comment.
At least aribb24.pc.in has no header and ends up installed (as /usr/lib64/pkgconfig/aribb24.pc). It's minor though.
There was a problem hiding this comment.
Pkg-config files are generally non-copyrightable (they contain only build instructions, nothing really original).
There was a problem hiding this comment.
Is there a policy about this? I understand the logic that the lowest common denominator of the source files is the real license, but I figure there has to be a good reason to ignore the declared package license in favor of our own investigation. LGPL-3 is a superset of LGPL-2.1+ so it should be safer to say the package is LGPL-3.
There was a problem hiding this comment.
Yeah, that's good enough for now. I've filed a bug upstream to verify it.
|
Also, I'm sorry we weren't able to look at it sooner. |
|
I'll test it in a minute. |
aribb24 is a library for decoding ARIB STD-B24 subtitles.
Closes: https://bugs.gentoo.org/655910
Package-Manager: Portage-2.3.36, Repoman-2.3.9