Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/libvirt-python: add python-3.6 support #8463

Closed
wants to merge 2 commits into from

Conversation

gyakovlev
Copy link
Member

@gyakovlev gyakovlev commented May 19, 2018

Upstream tests it with python-3.6 using travis for a while. Please add support in gentoo =)

>>> Test phase: dev-python/libvirt-python-4.2.0
 * python2_7: running distutils-r1_run_phase python_test
python2.7 setup.py test
running test
/usr/bin/python2.7 sanitytest.py build/lib.linux-x86_64-2.7 /usr/share/libvirt/api/libvirt-api.xml
/usr/bin/python2.7 /usr/bin/nosetests
..
----------------------------------------------------------------------
Ran 2 tests in 0.040s

OK
 * python3_6: running distutils-r1_run_phase python_test
python3.6 setup.py test
running test
/usr/bin/python3.6 sanitytest.py build/lib.linux-x86_64-3.6 /usr/share/libvirt/api/libvirt-api.xml
/usr/bin/python3.6 /usr/bin/nosetests
..
----------------------------------------------------------------------
Ran 2 tests in 0.045s

OK
 * python2_7: running distutils-r1_run_phase _distutils-r1_clean_egg_info
 * python3_6: running distutils-r1_run_phase _distutils-r1_clean_egg_info
>>> Completed testing dev-python/libvirt-python-4.2.0
>>> Test phase: dev-python/libvirt-python-4.3.0
 * python2_7: running distutils-r1_run_phase python_test
python2.7 setup.py test
running test
/usr/bin/python2.7 sanitytest.py build/lib.linux-x86_64-2.7 /usr/share/libvirt/api/libvirt-api.xml
/usr/bin/python2.7 /usr/bin/nosetests
upstream tests it with python3.6 in travis for a while, please add support =)
..
----------------------------------------------------------------------
Ran 2 tests in 0.040s

OK
 * python3_6: running distutils-r1_run_phase python_test
python3.6 setup.py test
running test
/usr/bin/python3.6 sanitytest.py build/lib.linux-x86_64-3.6 /usr/share/libvirt/api/libvirt-api.xml
/usr/bin/python3.6 /usr/bin/nosetests
..
----------------------------------------------------------------------
Ran 2 tests in 0.045s

OK
 * python2_7: running distutils-r1_run_phase _distutils-r1_clean_egg_info
 * python3_6: running distutils-r1_run_phase _distutils-r1_clean_egg_info
>>> Completed testing dev-python/libvirt-python-4.3.0\

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-python/libvirt-python

dev-python/libvirt-python: @tamiko, @gentoo/virtualization

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.


Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 19, 2018
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-05-19 01:59 UTC
Newest commit scanned: 0737baf
Status: ✅ good

No issues found


Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

@@ -3,7 +3,7 @@

EAPI=6

PYTHON_COMPAT=( python{2_7,3_4,3_5} )
PYTHON_COMPAT=( python{2_7,3_4,3_5,3_6} )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the change in the unstable versions 4.2.0, 4.3.0 and 9999. You also have to do a revision bump, meaning rename 4.2.0 to 4.2.0-r1, and 4.3.0 to 4.3.0-r1 (keep 9999 as is).

Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@gyakovlev gyakovlev deleted the libvirt-python-3.6 branch May 28, 2018 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
3 participants