Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-libs/signon-oauth2: do not install examples #8579

Closed
wants to merge 1 commit into from

Conversation

matijaskala
Copy link
Contributor

This fixes file collision with kde-apps/kaccounts-providers

Also bumped to EAPI 7

This fixes file collision with kde-apps/kaccounts-providers
@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-libs/signon-oauth2

net-libs/signon-oauth2: @gentoo/kde

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 25, 2018
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-05-25 17:15 UTC
Newest commit scanned: 5e16b46
Status: ✅ good

No issues found


Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no bug report for either package nor a build.log about said collisions, can you clarify?

@matijaskala
Copy link
Contributor Author

Both packages install a file, named /etc/signon-ui/webkit-options.d/www.facebook.com.conf.
It seems that portage doesn't correctly detect file collision inside /etc. Instead of an error it just triggers etc-update mechanism.

@a17r
Copy link
Member

a17r commented May 29, 2018

This is probably a leftover file in kaccounts-providers. Since both the provider and service files were disabled long ago in https://cgit.kde.org/kaccounts-providers.git/commit/services/disabled?id=0589543970fe2661364e5ad8990b0c095e672e1a and https://cgit.kde.org/kaccounts-providers.git/commit/?id=1c99a9bcf4593b0e8b0b6c05c47a100bbb710a08

@a17r
Copy link
Member

a17r commented May 29, 2018

Whatever purpose it fulfils in kaccounts-providers though, you're right it is part of examples in signon-oauth2. I am going to disable them properly in a 0.24 version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants