Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-admin/collectd: Bumped to v5.5.1 #887

Merged
merged 1 commit into from Feb 29, 2016

Conversation

Whissi
Copy link
Contributor

@Whissi Whissi commented Feb 19, 2016

  • New upstream version (Closes #570766, #517060)
  • Non-functional mongodb plugin disabled in ebuild (see upstream
    issue kde-apps/kdeartwork*: Port to kf5 #492, closes #524400)
  • Multiple dependency problems fixed
  • linux-info eclass usage fixed (Closes #570778)
  • Support for new plugins added (amqp, genericjmx, ipvs, modbus, sigrok,
    tail_csv, vserver, write_riemann)
  • PYTHON_SINGLE_TARGET support for Python 3.4 and 3.5 enabled
  • Documentation improved (USE flag description, elogs)
  • Linux capabilities usage expanded to improve running collectd as
    unprivileged user (disable via filecaps USE flag)
  • Runscript rewritten
    • Runscript now supports OpenRC's default status function
    • Runscript now guarantees service shutdown
    • Validating configuration before (re)starting daemon

@Whissi
Copy link
Contributor Author

Whissi commented Feb 19, 2016

@jbergstroem ping

@jbergstroem
Copy link
Contributor

Thanks for your work. Will review over the weekend.

@monsieurp monsieurp added bugfix assigned PR successfully assigned to the package maintainer(s). labels Feb 20, 2016
@gktrk
Copy link
Member

gktrk commented Feb 23, 2016

Is there a reason why "epatch ${PATCHES[@]}" is called on line 265? I believe the EAPI6 equivalent is eapply, unless the patches are not in p1 format.

@jbergstroem
Copy link
Contributor

@gktrk afaik its easier to call default in eapi6 to get PATCHES() applied (among other things).

@Whissi
Copy link
Contributor Author

Whissi commented Feb 23, 2016

Yes, because we provide our own SRC_PREPARE() function so we have to call epatch and eapply_user on our own.

In theory we could call default instead however if we ever have to apply a patch with different patch level we would have to rewrite so I chose this style on purpose.

@Whissi
Copy link
Contributor Author

Whissi commented Feb 23, 2016

However I re-read EAPI6's src_prepare() definition and will update the PR to switch to default usage and also eliminate eutils eclass usage.

- New upstream version (Closes #570766, #517060)

- Bumped to EAPI=6

- Non-functional mongodb plugin disabled in ebuild (see upstream
  issue gentoo#492, closes #524400)

- Multiple dependency problems fixed

- linux-info eclass usage fixed (Closes #570778)

- Support for new plugins added (amqp, genericjmx, ipvs, modbus, sigrok,
  tail_csv, vserver, write_riemann)

- PYTHON_SINGLE_TARGET support for Python 3.4 and 3.5 enabled

- Documentation improved (USE flag description, elogs)

- Linux capabilities usage expanded to improve running collectd as
  unprivileged user (disable via filecaps USE flag)

- Runscript rewritten

  - Runscript now supports OpenRC's default status function

  - Runscript now guarantees service shutdown

  - Validating configuration before (re)starting daemon
@jbergstroem
Copy link
Contributor

@Whissi yeah, sorry for not being clear enough; I meant invoking default to get parent functionality just like you implemented.

@monsieurp
Copy link
Member

@jbergstroem let us know when the PR's good go to!

@jbergstroem
Copy link
Contributor

LGTM

@gentoo-bot gentoo-bot merged commit 3b459b6 into gentoo:master Feb 29, 2016
gentoo-bot pushed a commit that referenced this pull request Feb 29, 2016
This PR bumps collectd to version 5.5.1 and fixes a raft of bugs.

See commit 3b459b6 for a lengthy explanation
concerning the changes involved.

Pull-Request: #887
Gentoo-Bug: https://bugs.gentoo.org/570766
Gentoo-Bug: https://bugs.gentoo.org/517060
Gentoo-Bug: https://bugs.gentoo.org/524400
Gentoo-Bug: https://bugs.gentoo.org/570778
Reporter: Thomas D <whissi@whissi.de>
Acked-by: Johan Bergström <bugs@bergstroem.nu>
Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
@Whissi Whissi deleted the collectd-5.5.1-bump branch March 14, 2016 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
5 participants