Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-block/targetcli-fb: add dbus dependency / bump to EAPI 7 #8972

Closed
wants to merge 10,000 commits into from
Closed

sys-block/targetcli-fb: add dbus dependency / bump to EAPI 7 #8972

wants to merge 10,000 commits into from

Conversation

diogocp
Copy link
Contributor

@diogocp diogocp commented Jun 25, 2018 •
edited

perfinion and others added 30 commits June 25, 2018 18:40
@perfinion
dev-python/jaraco-classes: amd64 stable
c84e86e 
Gentoo-bug: 658956
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@perfinion
dev-python/jaraco-itertools: amd64 stable
bec1147 
Gentoo-bug: 658956
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@perfinion
dev-python/jaraco-logging: amd64 stable
5c3e500 
Gentoo-bug: 658956
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@perfinion
dev-python/jaraco-stream: amd64 stable
04f9702 
Gentoo-bug: 658956
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@perfinion
dev-python/jaraco-text: amd64 stable
504a7fd 
Gentoo-bug: 658956
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@perfinion
dev-python/namespace-jaraco: amd64 stable
a38246a 
Gentoo-bug: 658956
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@perfinion
dev-python/jaraco-collections: amd64 stable
2368a5f 
Gentoo-bug: 658956
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@perfinion
dev-python/more-itertools: amd64 stable
8d9cc8b 
Gentoo-bug: 658956
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@perfinion
dev-python/jaraco-packaging: amd64 stable
a59dcdf 
Gentoo-bug: 658956
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@johu
x11-misc/xbatt: Migrate to eapi7-ver eclass
b210e58 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@benkohler
app-admin/ps_mem: new package
5d6f476 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
games-strategy/asc: Replaced freetype-config with pkg-config
e540169 
Closes: https://bugs.gentoo.org/657998
Package-Manager: Portage-2.3.40, Repoman-2.3.9
x11-libs/pango: Stable for HPPA too.
71f071f 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
RepoMan-Options: --ignore-arches
@candrews
app-admin/needrestart: 3.3 version bump
6e7d09d 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
sys-block/fio: bump to v3.7
7beb844 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
dev-games/clanlib: Replaced freetype-config with pkg-config
3f8084c 
Bug: https://bugs.gentoo.org/658424
Package-Manager: Portage-2.3.40, Repoman-2.3.9
dev-util/imediff2: Add myself as a maintainer
8852af0
dev-util/imediff2: Add python 3 support
f17145b 
Closes: https://bugs.gentoo.org/650050
Package-Manager: Portage-2.3.40, Repoman-2.3.9
dev-util/imediff2: Drop old revision
11a8aa4 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
app-office/calcurse: Again sys-libs/ncurses[tinfo] (bug #529804).
bbb7be5 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@klausman
dev-erlang/epam-1.0.2-r0: alpha stable
e37ece0 
Gentoo-Bug: http://bugs.gentoo.org/649202
@klausman
dev-erlang/p1_utils-1.0.8-r0: alpha stable
acc740f 
Gentoo-Bug: http://bugs.gentoo.org/649202
@klausman
dev-lang/erlang-20.3-r0: alpha stable
524ad22 
Gentoo-Bug: http://bugs.gentoo.org/649202
@klausman
dev-util/rebar-2.6.1-r0: alpha stable
2004ce8 
Gentoo-Bug: http://bugs.gentoo.org/649202
@klausman
net-libs/libssh2-1.8.0-r1: alpha stable
8c4d9b4 
Gentoo-Bug: http://bugs.gentoo.org/651590
@klausman
app-editors/joe-4.6-r0: alpha stable
ccfdc44 
Gentoo-Bug: http://bugs.gentoo.org/654704
@klausman
app-text/texlive-core-2017-r4: alpha stable
6f056fd 
Gentoo-Bug: http://bugs.gentoo.org/655052
@klausman
app-shells/gentoo-bashcomp-20180302-r0: alpha stable
875473b 
Gentoo-Bug: http://bugs.gentoo.org/655328
@klausman
app-text/gocr-0.50-r0: alpha stable
ce161ad 
Gentoo-Bug: http://bugs.gentoo.org/655330
@klausman
sys-auth/libfprint-0.6.0-r2: alpha stable
267f334 
Gentoo-Bug: http://bugs.gentoo.org/655340
Whissi and others added 24 commits June 26, 2018 01:20
@Whissi
dev-python/python-debian: x86 stable (bug #658844)
23596ca 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/pytools: x86 stable (bug #659074)
4999f3f 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/pyxattr: x86 stable (bug #659076)
bd2d393 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/pyzor: x86 stable (bug #658546)
4024302 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
sci-geosciences/qgis: x86 stable (bug #658948)
c77e045 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
x11-misc/rofi: x86 stable (bug #645402)
11dec6b 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/rpyc: x86 stable (bug #659078)
fca3f9a 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/rtslib-fb: x86 stable (bug #659080)
86ab0b9 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/pyudev: x86 stable (bug #659080)
f162064 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-lang/scala: x86 stable (bug #637940)
7e9f554 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-java/sbt: x86 stable (bug #637940)
412c1b6 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
media-libs/sdl-pango: x86 stable (bug #658766)
002f84b 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/semantic_version: x86 stable (bug #658950)
ed045a3 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
app-text/texlive-core: x86 stable (bug #655052)
83e8388 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
app-admin/ulogd: x86 stable (bug #658960)
eee3db4 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
app-office/unoconv: x86 stable (bug #658870)
19b7d01 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/vcrpy: x86 stable (bug #652856)
78b535e 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/yarl: x86 stable (bug #652856)
52ff94c 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
dev-python/multidict: x86 stable (bug #652856)
f473a83 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@Whissi
media-video/subliminal: x86 stable (bug #658916)
b8a08ca 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@lucianposton @blueness
app-backup/spideroak-bin: Downgrade to 7.2.0
1d96dce 
Bug: https://bugs.gentoo.org/637956

Making the package -9999 when it isn't actually a live ebuild only
hides the bug from devs. It still affects users trying to emerge the
package because the distfile is still verified against the manifest.

Package-Manager: Portage-2.3.40, Repoman-2.3.9
@diogocp
sys-block/targetcli-fb: add dbus dependency
c070255 
Closes: https://bugs.gentoo.org/657610
Reported-by: István Haraszti <haraszti.istvan@borsonline.hu>
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@diogocp
sys-block/targetcli-fb: bump to EAPI 7
8a560f0 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@diogocp
sys-block/targetcli-fb: drop old
31298de 
Package-Manager: Portage-2.3.40, Repoman-2.3.9
@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: sys-block/targetcli-fb

sys-block/targetcli-fb: @diogocp, @gentoo/proxy-maint

Bugs linked: 657610

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jun 25, 2018
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-06-26 00:34 UTC
Newest commit scanned: 31298de
Status: ✅ good

No issues found

Zlogene
Zlogene suggested changes Jun 26, 2018
View reviewed changes
sys-block/targetcli-fb/targetcli-fb-2.1.48-r3.ebuild Outdated
@@ -17,7 +17,7 @@ LICENSE="Apache-2.0"
SLOT="0"
KEYWORDS="~amd64 ~x86"

DEPEND="dev-python/setuptools[${PYTHON_USEDEP}]"
BDEPEND="dev-python/setuptools[${PYTHON_USEDEP}]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEPEND

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed The ultimate guide to EAPI 7:

  1. Dependencies that need to be run during the build, and therefore must run on the system used to build packages (CBUILD). Those include toolchain, build system tooling (autotools, CMake), various language interpreters (Perl, Python), preprocessors (SWIG) and other tools (e.g. pkg-config). Those are placed in BDEPEND now.
  2. Dependencies that need to be compiled for the real system, and present for the toolchain to work. Those mostly include libraries since the link editor needs to link to them. Those remain as DEPEND.

While it doesn't list it explictly, wouldn't setuptools fall under "build system tooling", and thus go into BDEPEND?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zlogene Zlogene Zlogene requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone