app-i18n/ibus-libpinyin: Version bump 1.10.0 & fix boost configure #8986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package-Manager: Portage-2.3.40_p15, Repoman-2.3.9_p247
Package-Manager: Portage-2.3.40_p15, Repoman-2.3.9_p247
Package-Manager: Portage-2.3.40_p15, Repoman-2.3.9_p247
Closes: https://bugs.gentoo.org/659242 Package-Manager: Portage-2.3.40_p15, Repoman-2.3.9_p247
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Signed-off-by: Jan Vesely <jano.vesely@gmail.com> Closes: gentoo#8966
Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.41, Repoman-2.3.9
Package-Manager: Portage-2.3.41, Repoman-2.3.9
Package-Manager: Portage-2.3.41, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Package-Manager: Portage-2.3.40, Repoman-2.3.9
1.9.3-r1 - This patches issue with latest GCC on configure with boost 1.10.0 - This includes above patch, and also update to new major version I submitted the patch/fix upstream as pull request libpinyin/ibus-libpinyin#134 and it has been merged (basically updating the boost.m4 macro to latest) 1.10.0 has additional changes as upstream has moved configuration settings to gsettings (now requires gnome2_utils eclass) Closes: https://bugs.gentoo.org/659328 Package-Manager: Portage-2.3.40, Repoman-2.3.9
|
Pull Request assignment Areas affected: ebuilds app-i18n/ibus-libpinyin: Bugs linked: 659328 In order to force reassignment and/or bug reference scan, please append |
gentoo-bot
added
assigned
Arfrever
reviewed
Jun 28, 2018
| } | ||
|
|
||
| pkg_preinst() { | ||
| gnome2_schemas_savelist |
There was a problem hiding this comment.
This is unnecessary. Please drop whole pkg_preinst().
Documentation of gnome2_schemas_savelist() in gnome2-utils.eclass says:
This is only necessary for eclass implementations that call gnome2_schemas_update conditionally.
Arfrever
reviewed
Jun 28, 2018
| PYTHON_COMPAT=( python{2_7,3_4,3_5,3_6} ) | ||
| PYTHON_REQ_USE="sqlite(+)" | ||
|
|
||
| inherit autotools python-single-r1 gnome2-utils |
There was a problem hiding this comment.
inherit autotools gnome2-utils python-single-r1
There was a problem hiding this comment.
thanks, makes sense - changes applied just as suggested.
sorted imports in alphabetical order removed uneeded pkg_preinst / gnome2_schemas_savelist Package-Manager: Portage-2.3.40, Repoman-2.3.9
|
Pull request CI report Report generated at: 2018-06-28 07:54 UTC No issues found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.9.3-r1 - This patches issue with latest GCC on configure with boost
1.10.0 - This includes above patch, and also update to new major version
I submitted the patch/fix upstream as pull request
libpinyin/ibus-libpinyin#134
and it has been merged (basically updating the boost.m4 macro to latest)
1.10.0 has additional changes as upstream has moved configuration settings
to gsettings (now requires gnome2_utils eclass)
Closes: https://bugs.gentoo.org/659328
Package-Manager: Portage-2.3.40, Repoman-2.3.9