games-engines/gargoyle: fix build on recent GCC, ebuild improvements, cancel last-rites #9052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request assignment Areas affected: ebuilds games-engines/gargoyle: @gentoo/games Bugs linked: 642996 In order to force reassignment and/or bug reference scan, please append |
gentoo-bot
added
assigned
tonyvroon
suggested changes
Jul 11, 2018
| @@ -69,7 +68,7 @@ src_compile() { | |||
| -sC++="$(tc-getCXX) ${CXXFLAGS}" \ | |||
| -sCXX="$(tc-getCXX) ${CXXFLAGS}" \ | |||
| -sC++FLAGS="" \ | |||
| -sGARGLKINI="${GAMES_SYSCONFDIR}/garglk.ini" \ | |||
| -sGARGLKINI="/etc/garglk.ini" \ | |||
There was a problem hiding this comment.
This changes the location of a file on disk, from /etc/games to /etc; this means you'll need to bump the revision on the ebuild.
Bumped EAPI, removed the use of games.eclass, fixed a runtime error due to a no longer needed sed, create relative instead of absolute symlinks. Revbump due to a file location change. Closes: https://bugs.gentoo.org/642996 Package-Manager: Portage-2.3.42, Repoman-2.3.9
…fixed Package-Manager: Portage-2.3.42, Repoman-2.3.9
realnc
changed the title
|
Pull request CI report Report generated at: 2018-07-13 00:14 UTC All QA issues have been fixed! |
tonyvroon
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped EAPI, removed the use of games.eclass, fixed a runtime error due
to a no longer needed sed, create relative instead of absolute symlinks.
Revbump due to a file location change.
Cancel games-engines/gargoyle last-rites as build issue is fixed.
Closes: https://bugs.gentoo.org/642996
Package-Manager: Portage-2.3.42, Repoman-2.3.9