net-misc/unison: bump to 2.51.2 #9173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 10, 2018 14:02
This adds support for slotted fsmonitor which will be added in upcoming net-misc/unison ebuilds Package-Manager: Portage-2.3.41, Repoman-2.3.9
Otherwise, we can't install a parallel version (which is upcoming). Also, bump to EAPI 7 and restrict tests (see comment) Package-Manager: Portage-2.3.41, Repoman-2.3.9
Closes: https://bugs.gentoo.org/651972 Package-Manager: Portage-2.3.41, Repoman-2.3.9
ghost
self-assigned this
ghost
requested a review
from 
Zlogene
suggested changes
Jul 11, 2018
net-misc/unison/unison-2.51.2.ebuild
Outdated
|
|
||
| EAPI="7" | ||
|
|
||
| IUSE="gtk doc static debug threads +ocamlopt test" |
There was a problem hiding this comment.
at least move it acording to variables order ;)
net-misc/unison/unison-2.51.2.ebuild
Outdated
| || ( net-misc/x11-ssh-askpass net-misc/ssh-askpass-fullscreen ) ) | ||
| >=app-eselect/eselect-unison-0.4" | ||
|
|
||
| SRC_URI="https://www.seas.upenn.edu/~bcpierce/unison/download/releases/${P}/${P}.tar.gz |
|
Pull request CI report Report generated at: 2018-07-12 12:54 UTC No issues found |
heroxbd
suggested changes
Aug 27, 2018
| dodir ${MODULEDIR} | ||
| insinto ${MODULEDIR} | ||
| newins "${FILESDIR}/${MODULE}.eselect-${PVR}" ${MODULE}.eselect \ | ||
| || die "failed to install" |
There was a problem hiding this comment.
You don't need || die for ebuild helpers like newins.
|
Done. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@heroxbd here it is. I had to bump
eselect-unisonas well as revbump2.48.4so that it slotsunison-fsmonitor.