net-im/telegram-desktop-bin: bump to 1.3.10 and disable auto-updates #9218
Conversation
|
Pull Request assignment Areas affected: ebuilds net-im/telegram-desktop-bin: @henning-schild, @NP-Hardass, @gentoo/proxy-maint No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment. In order to force reassignment and/or bug reference scan, please append |
gentoo-bot
added
self-maintained
henning-schild
force-pushed
the
henning/staging5
branch
from
d9dbcc6
to
547b66b
Compare
|
@henning-schild if this closes out the bug, your tag in the first commit should be "Closes" not "Bugs" How exactly was this issue resolved? Do our users need to do anything specifically, or is it handled in the build automatically? |
|
The new ebuild makes sure the software is always started with the updater disabled, users just have to upgrade to that new version. I think I have never seen Closes in that context, will check. |
henning-schild
force-pushed
the
henning/staging5
branch
from
547b66b
to
37d6a48
Compare
|
@NP-Hardass switched to using "Closes" |
| S="${WORKDIR}/Telegram" | ||
|
|
||
| src_install() { | ||
| into /usr/lib/${PN}/ |
There was a problem hiding this comment.
not that you need ending slash here
| src_install() { | ||
| into /usr/lib/${PN}/ | ||
| newbin "${S}/Telegram" ${PN} | ||
| into /usr/ |
henning-schild
force-pushed
the
henning/staging5
branch
from
37d6a48
to
da1ab19
Compare
| x11-libs/libX11 | ||
| >=x11-libs/libxcb-1.10[xkb] | ||
| " | ||
| DEPEND="" |
There was a problem hiding this comment.
one more nitpick: why do you need empty variable then?
There was a problem hiding this comment.
good point! was inherited from a previous ebuild, included a commit that drops that from all ebuilds
There was a problem hiding this comment.
@henning-schild do not forget to squash it as well
Signed-off-by: Henning Schild <henning@hennsch.de>
henning-schild
force-pushed
the
henning/staging5
branch
from
da1ab19
to
325fbc9
Compare
This version bump uses a new upstream feature to tell the binary that it should not check for updates itself. The ebuild installs the binary to /usr/lib/ and deploys a wrapper to /usr/bin/. Closes: https://bugs.gentoo.org/618662 Signed-off-by: Henning Schild <henning@hennsch.de>
Signed-off-by: Henning Schild <henning@hennsch.de>
henning-schild
force-pushed
the
henning/staging5
branch
from
325fbc9
to
c86b7d8
Compare
|
Pull request CI report Report generated at: 2018-07-15 20:35 UTC No issues found |
No description provided.