Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-libs/mini-xml: bump to version 2.11 #9220

Closed
wants to merge 1 commit into from

Conversation

ConiKost
Copy link
Contributor

Closes: https://bugs.gentoo.org/661102
Package-Manager: Portage-2.3.42, Repoman-2.3.9

@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-libs/mini-xml

dev-libs/mini-xml: ruepel[at]gmx.li, @gentoo/proxy-maint

Bugs linked: 661102

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 13, 2018
src_install() {
emake DSTROOT="${ED}" install

! use static-libs && rm "${ED}"/usr/$(get_libdir)/libmxml.a || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this line a bit less complicated using an if statement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Since Maintainer retired, I can take ownership too..

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-07-29 00:55 UTC
Newest commit scanned: 5019e61
Status: ✅ good

All QA issues have been fixed!

emake DSTROOT="${ED}" install

if ! use static-libs; then
rm "${ED}"/usr/$(get_libdir)/libmxml.a || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double slash have you here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thanks.

upon schema files or other sources of definition information.
</longdescription>
<use>
<flag name="ansi">Set full ANSI C mode</flag>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

@ConiKost ConiKost Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, looking into the code, I understand it wrong. The code adds CFLAGS="-ansi -pedantic, when this use flag is enabled. Is this valid?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have any value for the user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, removed all ansi stuff, since it's anyway disabled by default.

Closes: https://bugs.gentoo.org/661102
Package-Manager: Portage-2.3.44, Repoman-2.3.10
@mgorny
Copy link
Member

mgorny commented Aug 7, 2018

Thanks!

@gentoo-bot gentoo-bot closed this in a2a14d3 Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants