New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-libs/mini-xml: bump to version 2.11 #9220
Conversation
Pull Request assignment Areas affected: ebuilds dev-libs/mini-xml: Bugs linked: 661102 In order to force reassignment and/or bug reference scan, please append |
src_install() { | ||
emake DSTROOT="${ED}" install | ||
|
||
! use static-libs && rm "${ED}"/usr/$(get_libdir)/libmxml.a || die |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this line a bit less complicated using an if
statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Since Maintainer retired, I can take ownership too..
Pull request CI report Report generated at: 2018-07-29 00:55 UTC All QA issues have been fixed! |
emake DSTROOT="${ED}" install | ||
|
||
if ! use static-libs; then | ||
rm "${ED}"/usr/$(get_libdir)/libmxml.a || die |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double slash have you here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed, thanks.
dev-libs/mini-xml/metadata.xml
Outdated
upon schema files or other sources of definition information. | ||
</longdescription> | ||
<use> | ||
<flag name="ansi">Set full ANSI C mode</flag> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, looking into the code, I understand it wrong. The code adds CFLAGS="-ansi -pedantic
, when this use flag is enabled. Is this valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't have any value for the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, removed all ansi
stuff, since it's anyway disabled by default.
Closes: https://bugs.gentoo.org/661102 Package-Manager: Portage-2.3.44, Repoman-2.3.10
Thanks! |
Closes: https://bugs.gentoo.org/661102
Package-Manager: Portage-2.3.42, Repoman-2.3.9