Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11-themes/numix-gtk-theme: new package #9270

Closed
wants to merge 1 commit into from
Closed

x11-themes/numix-gtk-theme: new package #9270

wants to merge 1 commit into from

Conversation

juippis
Copy link
Member

@juippis juippis commented Jul 18, 2018

I just realized I've been using this theme for a long time, and there's a bug open asking for it to be added. So why not proxy-maintain it then :)

Doubt the emake in here needs die, but it can't hurt either having it.

Closes: https://bugs.gentoo.org/524176
Package-Manager: Portage[mgorny]-2.3.43.2
@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: x11-themes/numix-gtk-theme

x11-themes/numix-gtk-theme: @gentoo/proxy-maint (new package)

Bugs linked: 524176

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 18, 2018
@juippis juippis deleted the numix-gtk-theme.new_package branch July 23, 2018 11:04
@Zlogene
Copy link
Contributor

Zlogene commented Aug 30, 2018

@juippis please be careful about what you write next time, src_install() is not needed here and pure legacy

@juippis
Copy link
Member Author

juippis commented Aug 30, 2018

Hey, yeah I had this in my TODO:

 - numix-gtk-theme: src_install() can probably be removed, or replaced by 'default'

but I see you fixed it already. Thanks for that.

I get better at writing ebuilds all the time. I've been using this package since 2016 and I guess I pushed my latest working ebuild, but realized that src_install thing later (might've received feedback on other packages using it). Still, thanks for pointing it out and guidance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants