dev-util/cgdb test fixes + eapi bump + remove old

[nado]

Please do not merge yet.

@toralf could you run these modifications on your tinderbox to see if the bug is fixed ? It was reported by your system initially so… That would be awesome.

[tonyvroon]

You are removing the last stable ebuild for amd64, ppc, ppc64 & x86. Please leave 0.6.7; even if that is a deprecated EAPI and causes a warning from repoman.

[nado]

@gentoochainsaw please have a second look, I left 0.6.8 which has the same keywords as 0.6.7.
There shouldnt be any problem about that.

[tonyvroon]

Agreed, that wasn't very clear in the diff but on second look the change is fine. Awaiting tinderbox all clear from @toralf

[mgorny]

Ping, guys. Can we merge this finally?

[nado]

If someone can help me understand how to test in a "non interactive shell", I might be able to test it myself with conditions similar as Toralf's tinderbox.

[mgorny]

Well, for bash-completion it just failed for me when running via Portage. Maybe add --jobs to make it more disconnected.

[nado]

I could not reproduce the bug with --jobs (which is in my default opts), so I'm not even sure this is the right fix.

[toralf]

dev-util/cgdb-0.7.0::gentoo merged fine here at the tinderbox at an image having FEATURES=test

[nado]

Great, can it be merged? :)

[mgorny]

Signed-off-by needs to contain your real name.

[nado]

Done

[gentoo-bot]

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-util/cgdb

dev-util/cgdb: @nado, @gentoo/proxy-maint

Linked bugs

Bugs linked: 654986

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2018-10-22 15:38 UTC
Newest commit scanned: ecc32d8
Status: ✅ good

No issues found

[mgorny]

Hmm, are the tests supposed to actually work? Or this a partial solution?

make  check-DEJAGNU
make[2]: Entering directory '/tmp/portage/dev-util/cgdb-0.7.0-r1/work/cgdb-0.7.0-abi_x86_32.x86/test'
Making a new site.exp file ...
srcdir='/tmp/portage/dev-util/cgdb-0.7.0-r1/work/cgdb-0.7.0/test'; export srcdir; \
EXPECT=expect; export EXPECT; \
if /bin/sh -c "runtest --version" > /dev/null 2>&1; then \
  exit_status=0; l='kui.base'; for tool in $l; do \
    if runtest --tool $tool --srcdir $srcdir  ; \
    then :; else exit_status=1; fi; \
  done; \
else echo "WARNING: could not find 'runtest'" 1>&2; :;\
fi; \
exit $exit_status
WARNING: Couldn't find the global config file.
WARNING: Couldn't find tool init file
Test run by portage on Mon Oct 22 21:48:14 2018
Native configuration is i686-pc-linux-gnu

		=== kui.base tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /tmp/portage/dev-util/cgdb-0.7.0-r1/work/cgdb-0.7.0/test/config/unix.exp as tool-and-target-specific interface file.
Running /tmp/portage/dev-util/cgdb-0.7.0-r1/work/cgdb-0.7.0/test/kui.base/basic.exp ...
Error starting program
make[2]: *** [Makefile:278: check-DEJAGNU] Error 1
make[2]: Leaving directory '/tmp/portage/dev-util/cgdb-0.7.0-r1/work/cgdb-0.7.0-abi_x86_32.x86/test'
make[1]: *** [Makefile:353: check-am] Error 2
make[1]: Leaving directory '/tmp/portage/dev-util/cgdb-0.7.0-r1/work/cgdb-0.7.0-abi_x86_32.x86/test'
make: *** [Makefile:387: check-recursive] Error 1
emake failed

[nado]

They are supposed to work, if you could send me some details on your setup, I'd like to try reproducing it, I didnt manage to do that up til now.

[mgorny]

$ cgdb 
Segmentation fault (core dumped)

That might be a tip.

(gdb) bt
#0  0x00007ffff7bbd879 in termattrs_sp () from /lib64/libncursesw.so.6
#1  0x00007ffff7bbac10 in _nc_setupscreen_sp () from /lib64/libncursesw.so.6
#2  0x00007ffff7bb628d in newterm_sp () from /lib64/libncursesw.so.6
#3  0x00007ffff7bb6747 in newterm () from /lib64/libncursesw.so.6
#4  0x00007ffff7bb26bb in initscr () from /lib64/libncursesw.so.6

Probably related to https://bugs.gentoo.org/669096. You may try upgrading gdb to 8.2-r1 or switching USE=tinfo on on ncurses.

[mgorny]

I'm going to merge this since it apparently doesn't make things worse. cgdb still segfaults, though.

[nado]

Yeah, sorry, I didnt spend much time on my workstation and had to do a bunch of upgrades before I could set up the appropriate test environment.
I'll post updates when I'll get to it.