Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-vcs/easygit: 1.7.5.2 version bump #9362

Closed
wants to merge 1 commit into from
Closed

dev-vcs/easygit: 1.7.5.2 version bump #9362

wants to merge 1 commit into from

Conversation

culot
Copy link
Contributor

@culot culot commented Jul 27, 2018 •
edited by jonasstein

@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-vcs/easygit

dev-vcs/easygit: @gentoo/proxy-maint (maintainer needed)

Bugs linked: 662254

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 27, 2018
mgorny
mgorny requested changes Jul 27, 2018
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as @jonasstein tried to say, replace Bug with Closes to automatically close the relevant bug.

dev-vcs/easygit/easygit-1.7.5.2.ebuild Outdated

EAPI=6

MY_PN="eg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this variable. It doesn't really help with anything, and replaces two characters with eight…

dev-vcs/easygit/easygit-1.7.5.2.ebuild Outdated

DESCRIPTION="Easy GIT (eg), a frontend for git designed for former cvs and svn users"
HOMEPAGE="https://www.gnome.org/~newren/eg/"
SRC_URI="https://www.gnome.org/~newren/${MY_PN}/download/${PV}/${MY_PN} -> ${PF}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PF is incorrect here. Revisions are intended for internal Gentoo use, and must not be used for versioning sources.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@culot: use ${P} instead.

dev-vcs/easygit/easygit-1.7.5.2.ebuild Outdated
dev-lang/perl"

src_unpack() {
mkdir "${S}" || die
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't create unnecessary directories, set S=${WORKDIR} instead.

dev-vcs/easygit/easygit-1.7.5.2.ebuild Outdated
cp "${DISTDIR}/${PF}" "${S}/${MY_PN}" || die
}

src_compile() { :; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually need to do this? Unless I'm mistaken, the default would do nothing here.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-07-30 09:36 UTC
Newest commit scanned: 6655315
Status: ✅ good

No issues found

@mgorny
Copy link
Member

mgorny commented Jul 30, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurp monsieurp monsieurp left review comments

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
5 participants
@culot @gentoo-bot @gentoo-repo-qa-bot @mgorny @monsieurp