net-im/telegram-desktop-bin: exclude from session management #9366
Conversation
|
Pull Request assignment Areas affected: ebuilds net-im/telegram-desktop-bin: @henning-schild, @NP-Hardass, @gentoo/proxy-maint Bugs linked: 662330 In order to force reassignment and/or bug reference scan, please append |
gentoo-bot
added
self-maintained
| into /usr/lib/${PN} | ||
| newbin "${S}/Telegram" ${PN} | ||
| into /usr | ||
| newbin "${FILESDIR}"/${PN}-${PR} "telegram-desktop" |
| S="${WORKDIR}/Telegram" | ||
|
|
||
| src_install() { | ||
| into /usr/lib/${PN} |
There was a problem hiding this comment.
This is not a valid use of into. Please use exeinto/doexe instead.
|
|
||
| src_install() { | ||
| into /usr/lib/${PN} | ||
| newbin "${S}/Telegram" ${PN} |
There was a problem hiding this comment.
Don't use absolute path (${S}) when it's the current directory.
henning-schild
force-pushed
the
henning/staging3
branch
2 times, most recently
from
05308d8
to
4b29069
Compare
| src_install() { | ||
| exeinto /usr/lib/${PN} | ||
| newexe "Telegram" ${PN} | ||
| into /usr |
There was a problem hiding this comment.
Why do you need to set the default?
There was a problem hiding this comment.
was a leftover from the previous "into"
|
|
||
| src_install() { | ||
| exeinto /usr/lib/${PN} | ||
| newexe "Telegram" ${PN} |
There was a problem hiding this comment.
you are right, we can keep that name, left it and changed the wrapper
henning-schild
force-pushed
the
henning/staging3
branch
from
4b29069
to
6444508
Compare
| src_install() { | ||
| exeinto /usr/lib/${PN} | ||
| doexe "Telegram" | ||
| newbin "${FILESDIR}"/${PN}-${PR} "telegram-desktop" |
There was a problem hiding this comment.
Please don't use PR here. This is going to cause trouble in the future, quite likely with someone going back to -r0 on next bump.
henning-schild
force-pushed
the
henning/staging3
branch
from
6444508
to
377fe66
Compare
| SLOT="0" | ||
| KEYWORDS="~amd64 ~x86" | ||
|
|
||
| QA_PREBUILT="usr/lib/${PN}/bin/${PN}" |
There was a problem hiding this comment.
fixed, sorry that was caused be the other changes, hopefully that is it now
Thanks for the thorough reviews!
The application seems to register with the X11 session manager but fails to follow the protocol for remembering its state. The result is that a session manager will restart it, and during that process the command line argument for disabling the internal updater gets lost. So on a restarted session the updater will be enabled again. Do not let the application register at the session manager in the first place, by unsetting the env variable used to find it. Closes: https://bugs.gentoo.org/662330 Signed-off-by: Henning Schild <henning@hennsch.de>
henning-schild
force-pushed
the
henning/staging3
branch
from
377fe66
to
9e80244
Compare
|
Pull request CI report Report generated at: 2018-08-17 05:56 UTC No issues found |
|
Thanks! |
The application seems to register with the X11 session manager but fails
to follow the protocol for remembering its state. The result is that a
session manager will restart it, and during that process the command
line argument for disabling the internal updater gets lost.
So on a restarted session the updater will be enabled again.
Do not let the application register at the session manager in the first
place, by unsetting the env variable used to find it.
Closes: https://bugs.gentoo.org/662330
Signed-off-by: Henning Schild henning@hennsch.de