Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/libcdaudio: EAPI7, improve ebuild #9368

Closed
wants to merge 1 commit into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented Jul 28, 2018

Hi,

This PR updates media-libs/libcdaudio for EAPI7.
Please review

diff -u

--- libcdaudio-0.99.12-r1.ebuild        2018-05-06 12:15:30.662164306 +0200
+++ libcdaudio-0.99.12-r2.ebuild        2018-07-28 19:42:11.369818530 +0200
@@ -1,9 +1,7 @@
 # Copyright 1999-2018 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=0
-
-inherit eutils
+EAPI=7
 
 DESCRIPTION="Library of cd audio related routines"
 HOMEPAGE="http://libcdaudio.sourceforge.net/"
@@ -11,22 +9,11 @@
 
 LICENSE="GPL-2"
 SLOT="0"
-KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 sparc x86 ~x86-fbsd"
-IUSE=""
+KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~mips ~ppc ~ppc64 ~sparc ~x86 ~x86-fbsd"
 
-src_unpack() {
-       unpack ${A}
-       cd "${S}"
-       epatch "${FILESDIR}"/${PN}-0.99-CAN-2005-0706.patch #84936
-       epatch "${FILESDIR}"/${P}-bug245649.patch
-}
+PATCHES=( "${FILESDIR}"/${PN}-0.99-CAN-2005-0706.patch
+       "${FILESDIR}"/${P}-bug245649.patch )
 
-src_compile() {
+src_configure() {
        econf --enable-threads
-       emake || die "compile problem."
-}
-
-src_install() {
-       emake DESTDIR="${D}" install || die "make install failed"
-       dodoc AUTHORS ChangeLog NEWS README TODO
 }

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jul 28, 2018
@mm1ke mm1ke changed the title media-libs/libcdaudio: EAPI7, improve ebuild [please reassign] media-libs/libcdaudio: EAPI7, improve ebuild Aug 4, 2018
@gentoo-bot gentoo-bot changed the title [please reassign] media-libs/libcdaudio: EAPI7, improve ebuild media-libs/libcdaudio: EAPI7, improve ebuild Aug 4, 2018
@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: media-libs/libcdaudio

media-libs/libcdaudio: @gentoo/sound

Bugs linked: 657150

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 4, 2018
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-08-04 21:15 UTC
Newest commit scanned: 690e08e
Status: ✅ good

No issues found

@a17r
Copy link
Member

a17r commented Aug 11, 2018

Please don't link to Tracker bugs if there is no dedicated bug for the package.

@mm1ke mm1ke deleted the upd-libcdaudio branch January 29, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants