Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/pytest-relaxed: Don't autoload the plugin #9402

Closed
wants to merge 3 commits into from
Closed

dev-python/pytest-relaxed: Don't autoload the plugin #9402

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2018

When installed, this plugins autoload everywhere pytest runs, breaking
pretty much everything in its wake. We patch out its entry point to
avoid autoloading. Packages using this plugin may load it manually by
adding "-p pytest_relaxed.plugin" to their pytest invocation.

Closes: https://bugs.gentoo.org/661218

What do you think @mgorny, @sbraz (and @gentoo/python in general)?

NOTE: I didn't have to touch paramiko to explicitly load the plugin because of https://github.com/paramiko/paramiko/blob/2.4.1/setup.cfg#L16

@ghost ghost requested review from mgorny and sbraz August 1, 2018 00:56
@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-python/fabric, dev-python/hpack, dev-python/invoke, dev-python/pillow, dev-python/pytest-relaxed

dev-python/fabric: @hsoft, @gentoo/python
dev-python/hpack: @dol-sen, @gentoo/python
dev-python/invoke: @gentoo/python
dev-python/pillow: @hsoft, @gentoo/python
dev-python/pytest-relaxed: @gentoo/python

Bugs linked: 661218

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 1, 2018

PATCHES=(
# We strip pytest-relaxed's entry point to stop it from autoloading on all
# tests. When this package is installed, it has the habit ob being
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo s/ob/of

@dol-sen
Copy link
Contributor

dol-sen commented Aug 1, 2018

I didn't know that "-p no:relaxed" was an option...

Thanks for these patches, this will fix things for the better :)

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current hacks are still necessary with the old versions, so please keep them for some more time. You can replace the blocker with !!<...-NEWVERSION or switch hpack to -p no:relaxed.

@ghost
Copy link
Author

ghost commented Aug 1, 2018

Ok, will leave hpack and pillow alone for a while

Virgil Dupras added 3 commits August 1, 2018 06:20
When installed, this plugins autoload everywhere pytest runs, breaking
pretty much everything in its wake. We patch out its entry point to
avoid autoloading. Packages using this plugin may load it manually by
adding "-p pytest_relaxed.plugin" to their pytest invocation.

Closes: https://bugs.gentoo.org/661218
Package-Manager: Portage-2.3.44, Repoman-2.3.10
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-08-01 10:55 UTC
Newest commit scanned: 9733f31
Status: ✅ good

No issues found

@ghost ghost closed this Aug 1, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants