New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-python/pytest-relaxed: Don't autoload the plugin #9402
Conversation
Pull Request assignment Areas affected: ebuilds dev-python/fabric: @hsoft, @gentoo/python Bugs linked: 661218 In order to force reassignment and/or bug reference scan, please append |
|
||
PATCHES=( | ||
# We strip pytest-relaxed's entry point to stop it from autoloading on all | ||
# tests. When this package is installed, it has the habit ob being |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo s/ob/of
I didn't know that "-p no:relaxed" was an option... Thanks for these patches, this will fix things for the better :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current hacks are still necessary with the old versions, so please keep them for some more time. You can replace the blocker with !!<...-NEWVERSION
or switch hpack to -p no:relaxed
.
Ok, will leave hpack and pillow alone for a while |
When installed, this plugins autoload everywhere pytest runs, breaking pretty much everything in its wake. We patch out its entry point to avoid autoloading. Packages using this plugin may load it manually by adding "-p pytest_relaxed.plugin" to their pytest invocation. Closes: https://bugs.gentoo.org/661218 Package-Manager: Portage-2.3.44, Repoman-2.3.10
Bug: https://bugs.gentoo.org/661218 Package-Manager: Portage-2.3.44, Repoman-2.3.10
Bug: https://bugs.gentoo.org/661218 Package-Manager: Portage-2.3.44, Repoman-2.3.10
Pull request CI report Report generated at: 2018-08-01 10:55 UTC No issues found |
When installed, this plugins autoload everywhere pytest runs, breaking
pretty much everything in its wake. We patch out its entry point to
avoid autoloading. Packages using this plugin may load it manually by
adding "-p pytest_relaxed.plugin" to their pytest invocation.
Closes: https://bugs.gentoo.org/661218
What do you think @mgorny, @sbraz (and @gentoo/python in general)?
NOTE: I didn't have to touch paramiko to explicitly load the plugin because of https://github.com/paramiko/paramiko/blob/2.4.1/setup.cfg#L16