x11-drivers/*: add workaround for hardened toolchain (forgotten with EAPI 7 bump)

[puleglot]

Closes: https://bugs.gentoo.org/661502

[gentoo-bot]

Pull Request assignment

Areas affected: ebuilds
Packages affected: x11-drivers/xf86-video-amdgpu

x11-drivers/xf86-video-amdgpu: @gentoo/x11

Bugs linked: 661502

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

[puleglot]

We probably need the same fix for all x11-drivers/* recently ported to EAPI 7

[mattst88]

This doesn't seem like an appropriate fix. What is your theory of the problem?

[puleglot]

Hardened toolchain adds -z,now to the linker flags. That's why xorg-2.eclass contains the following code:

[[ ${PN} == xf86-video-* || ${PN} == xf86-input-* ]] && DRIVER="yes"
...
xorg-2_flags_setup() {
...
    [[ ${PN} = xorg-server || -n ${DRIVER} ]] && append-ldflags -Wl,-z,lazy

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2018-08-01 19:55 UTC
Newest commit scanned: 8ff357b
Status: ✅ good

No issues found

[mattst88]

Ouch. That makes sense now. The intent was to avoid using xorg-2 unnecessarily, but it seems that it really does offer some important things that are easy to forget. I suspect the best thing to do is to remove the EAPI=7 bumps and wait until xorg-2 has EAPI=7 support.

[hanetzer]

@mattst88 fsck. Something to put into xorg-3, then. I was thinking maybe
some distinct sub-eclasses (like xorg-driver.eclass and others if needed)
would be a good idea, instead of one monolithic one for everything xorg
related.