net-analyzer/nload: EAPI=7, fix bug 663402 "speed graph rendering issue" #9543

ahippo · 2018-08-12T02:17:56Z

The first patch is a preparation, which adds -r1 ebuild, and fixes repoman warnings for it.
(switches to EAPI=7 and shortens the package description).
The second patch adds an upstream patch to fix the issue described in Gentoo bug 663402.

ahippo · 2018-08-12T05:12:17Z

build.log is attached to bug 663402.

jonasstein · 2018-08-13T19:06:49Z

net-analyzer/nload/nload-0.7.4-r1.ebuild

+
+inherit autotools
+
+DESCRIPTION="Real time network traffic and bandwidth usage monitor for the text console"


I think this is a bad translation and suggest
DESCRIPTION="Real time network traffic monitor for the command line interface"

OK, I'll fix the description and update the PR.

@jonasstein

Add -r1 ebuild to fix the following repoman warnings: """ DESCRIPTION.toolong 1 net-analyzer/nload/nload-0.7.4.ebuild: DESCRIPTION is 83 characters (max 80) repo.eapi-deprecated 1 net-analyzer/nload/nload-0.7.4.ebuild: 5 """ The description string is suggested by @jonasstein. Package-Manager: Portage-2.3.40, Repoman-2.3.9 Link: gentoo#9543 (comment)

ahippo · 2018-08-14T04:36:37Z

@jonasstein, I've updated the description per your suggestion.
Please, let me know if you have any other comments.

@jonasstein

Add -r1 ebuild to fix the following repoman warnings: """ DESCRIPTION.toolong 1 net-analyzer/nload/nload-0.7.4.ebuild: DESCRIPTION is 83 characters (max 80) repo.eapi-deprecated 1 net-analyzer/nload/nload-0.7.4.ebuild: 5 """ The description string is suggested by @jonasstein. Package-Manager: Portage-2.3.40, Repoman-2.3.9 Link: gentoo#9543 (comment)

ahippo · 2018-08-21T04:57:15Z

Looks like, @gentoo/netmon could use some help.
I've added myself as a proxied maintainer.
(unless @gentoo/proxy-maint has any objections)

If there is not much use of me being a proxied maintainer, simply discard the last commit before merging.

gentoo-bot · 2018-08-21T14:40:16Z

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-analyzer/nload

net-analyzer/nload: @gentoo/netmon

Bugs linked: 663402

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

ahippo · 2018-08-23T16:46:10Z

@mgorny, would Proxy Maint team be able to help me with merging this PR?
Sorry to call you out specifically, but looks like, I can't mention the whole @gentoo/proxy-maint team.

mgorny · 2018-08-23T20:07:26Z

net-analyzer/nload/nload-0.7.4-r1.ebuild

+HOMEPAGE="http://www.roland-riegel.de/nload/index.html"
+SRC_URI="http://www.roland-riegel.de/nload/${P}.tar.gz"
+
+LICENSE="GPL-2"


The LICENSE is wrong:

* This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version.

Good catch, thank you!
I'll fix and update the PR.

Link: gentoo#9543

@jonasstein

Add -r1 ebuild to fix the following repoman warnings: """ DESCRIPTION.toolong 1 net-analyzer/nload/nload-0.7.4.ebuild: DESCRIPTION is 83 characters (max 80) repo.eapi-deprecated 1 net-analyzer/nload/nload-0.7.4.ebuild: 5 """ The description string is suggested by @jonasstein. Correct the package license in the ebuild as pointed out by @mgorny. The source code says: """ /*************************************************************************** * * * This program is free software; you can redistribute it and/or modify * * it under the terms of the GNU General Public License as published by * * the Free Software Foundation; either version 2 of the License, or * * (at your option) any later version. * * * ***************************************************************************/ """ Link: gentoo#9543 (comment) Link: gentoo#9543 (comment) Package-Manager: Portage-2.3.40, Repoman-2.3.9

Apply the following patch from upstream: 8a93886 "Eliminate flicker on some terminals like rxvt (thanks to Alex Wilson)" This fixes network utilization graph rendering issue. (the text on the right side of the screen slides to the left together with graph updates) Closes: https://bugs.gentoo.org/663402 Closes: gentoo#9543 Package-Manager: Portage-2.3.40, Repoman-2.3.9

ahippo · 2018-08-24T02:53:58Z

I've fixed the license in commit a863959 (I've amended the fix).
Also, I reordered the commits, so that the last one is the one to close the PR.

mgorny · 2018-08-24T06:19:22Z

>>> /usr/share/man/man1/nload.1.gz.lz

Something is compressing installed manpages. Please make sure they are installed uncompressed so that Portage can compress them.

ahippo · 2018-08-24T19:49:30Z

/usr/share/man/man1/nload.1.gz.lz
Something is compressing installed manpages. Please make sure they are installed uncompressed so that Portage can compress them.

Oh, that's weird.
Thank you for pointing this out!
I didn't notice this somehow.

ahippo · 2018-08-25T02:44:19Z

/usr/share/man/man1/nload.1.gz.lz
Something is compressing installed manpages. Please make sure they are installed uncompressed so that Portage can compress them.

Oh, that's weird.
Thank you for pointing this out!
I didn't notice this somehow.

I didn't notice that because on my machine it installs the normal nload.1.bz2 manpage:

gzip -f /var/tmp/portage/net-analyzer/nload-0.7.4-r1/image/usr/share/man/man1/nload.1
...
>>> /usr/share/man/man1/nload.1.bz2

make install does compress the manpage with gzip, but ecompressdir handles this fine.
(I'm running sys-apps/portage-2.3.40-r1)

ecompressdir has a special code to run the proper decompressor saying "# not uncommon for packages to compress doc files themselves".
So, I'm not sure if the ebuild needs to handle this specially somehow.

docs/Makefile.am might be doing it wrong indeed -- it doesn't just use man1_MANS, but also defines an explicit install target for the manpage.
However, the change appears to be deliberate for some reason.

mgorny · 2018-08-25T05:24:42Z

You need to handle it. Portage implementation does not follow the standards, and I've deliberately changed it to catch this.

ahippo · 2018-08-25T15:31:53Z

You need to handle it. Portage implementation does not follow the standards, and I've deliberately changed it to catch this.

OK, let me fix the Makefile.am then.
By the way, what standard mandates this? PMS?

mgorny · 2018-08-25T16:27:12Z

Yes. It doesn't specify that files must be decompressed from other formats before compression.

Package managers like to compress man-pages on their own, because the type of compression for man-pages is user-configurable. In particular, Gentoo [1] doesn't want packages to compress their man-pages. Gentoo Portage has workarounds for this, but this is not specified in Package Manager Specification and results in extra compression-decompression pass. RPM also compresses man-pages itself (in `brp-compress`) (and similarly recompresses them as needed) rather than relying on packages to install compressed man-pages. Automake can handle installation of man-pages without the explicit "install" target, so use the standard automake-provided way of installing man-pages. It's also smart enough to package `nload.1.in` automatically. Don't specify an explicit man-page extension in .spec file as recommended by Fedora. [1] gentoo/gentoo#9543 (comment)

@mgorny

As pointed out by @mgorny [1], packages should not compress their man pages on their own. Instead, Portage needs to handle the compression. Currently, `ecompressdir` is smart enough to recompress the man-pages as needed. However, this is not a fully PMS-compliant behavior. So, patch the Makefile.am not to compress the man-page. A corresponding pull request is submitted upstream [2]. [1] gentoo#9543 (comment) [2] rolandriegel/nload#4

ahippo · 2018-08-26T02:53:01Z

Man-page compression should have been fixed in 68dc8ff

ahippo · 2018-08-26T02:54:21Z

Yes. It doesn't specify that files must be decompressed from other formats before compression.

I see.
Thanks for the info!

gentoo-repo-qa-bot · 2018-08-26T03:18:46Z

Pull request CI report

Report generated at: 2018-08-26 03:18 UTC
Newest commit scanned: 68dc8ff
Status: ✅ good

No issues found

mgorny · 2018-08-26T07:27:40Z

Thank you!

Link: #9543

@jonasstein

Add -r1 ebuild to fix the following repoman warnings: """ DESCRIPTION.toolong 1 net-analyzer/nload/nload-0.7.4.ebuild: DESCRIPTION is 83 characters (max 80) repo.eapi-deprecated 1 net-analyzer/nload/nload-0.7.4.ebuild: 5 """ The description string is suggested by @jonasstein. Correct the package license in the ebuild as pointed out by @mgorny. The source code says: """ /*************************************************************************** * * * This program is free software; you can redistribute it and/or modify * * it under the terms of the GNU General Public License as published by * * the Free Software Foundation; either version 2 of the License, or * * (at your option) any later version. * * * ***************************************************************************/ """ Link: #9543 (comment) Link: #9543 (comment) Package-Manager: Portage-2.3.40, Repoman-2.3.9

@mgorny

As pointed out by @mgorny [1], packages should not compress their man pages on their own. Instead, Portage needs to handle the compression. Currently, `ecompressdir` is smart enough to recompress the man-pages as needed. However, this is not a fully PMS-compliant behavior. So, patch the Makefile.am not to compress the man-page. A corresponding pull request is submitted upstream [2]. [1] #9543 (comment) [2] rolandriegel/nload#4 Closes: #9543

ahippo · 2018-08-26T17:13:37Z

Thank you for merging!

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 12, 2018

jonasstein reviewed Aug 13, 2018

View reviewed changes

ahippo force-pushed the net-analyzer/nload branch from 4637140 to 74d8534 Compare August 14, 2018 04:35

ahippo force-pushed the net-analyzer/nload branch from 74d8534 to 238aac1 Compare August 21, 2018 04:54

ahippo changed the title ~~net-analyzer/nload: EAPI=7, fix bug 663402 "speed graph rendering issue"~~ net-analyzer/nload: EAPI=7, fix bug 663402 "speed graph rendering issue" [please reassign] Aug 21, 2018

gentoo-bot changed the title ~~net-analyzer/nload: EAPI=7, fix bug 663402 "speed graph rendering issue" [please reassign]~~ net-analyzer/nload: EAPI=7, fix bug 663402 "speed graph rendering issue" Aug 21, 2018

mgorny requested changes Aug 23, 2018

View reviewed changes

ahippo added 3 commits August 24, 2018 05:44

net-analyzer/nload: add myself as a proxied maintainer

3eb8b39

Link: gentoo#9543

ahippo force-pushed the net-analyzer/nload branch from 238aac1 to 841a89e Compare August 24, 2018 02:50

ahippo mentioned this pull request Aug 26, 2018

Makefile,spec: don't compress the man-page rolandriegel/nload#4

Open

mgorny approved these changes Aug 26, 2018

View reviewed changes

gentoo-bot pushed a commit that referenced this pull request Aug 26, 2018

net-analyzer/nload: add myself as a proxied maintainer

8227cbc

Link: #9543

gentoo-bot closed this in fbbbabd Aug 26, 2018

ahippo deleted the net-analyzer/nload branch August 26, 2018 17:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net-analyzer/nload: EAPI=7, fix bug 663402 "speed graph rendering issue" #9543

net-analyzer/nload: EAPI=7, fix bug 663402 "speed graph rendering issue" #9543

ahippo commented Aug 12, 2018

ahippo commented Aug 12, 2018 •

edited

jonasstein Aug 13, 2018

ahippo Aug 13, 2018

ahippo commented Aug 14, 2018

ahippo commented Aug 21, 2018

gentoo-bot commented Aug 21, 2018

ahippo commented Aug 23, 2018

mgorny Aug 23, 2018

ahippo Aug 23, 2018

ahippo commented Aug 24, 2018

mgorny commented Aug 24, 2018

ahippo commented Aug 24, 2018 •

edited

ahippo commented Aug 25, 2018 •

edited

mgorny commented Aug 25, 2018

ahippo commented Aug 25, 2018

mgorny commented Aug 25, 2018

ahippo commented Aug 26, 2018

ahippo commented Aug 26, 2018

gentoo-repo-qa-bot commented Aug 26, 2018

mgorny commented Aug 26, 2018

ahippo commented Aug 26, 2018


		inherit autotools

		DESCRIPTION="Real time network traffic and bandwidth usage monitor for the text console"

net-analyzer/nload: EAPI=7, fix bug 663402 "speed graph rendering issue" #9543

net-analyzer/nload: EAPI=7, fix bug 663402 "speed graph rendering issue" #9543

Conversation

ahippo commented Aug 12, 2018

ahippo commented Aug 12, 2018 • edited

jonasstein Aug 13, 2018

Choose a reason for hiding this comment

ahippo Aug 13, 2018

Choose a reason for hiding this comment

ahippo commented Aug 14, 2018

ahippo commented Aug 21, 2018

gentoo-bot commented Aug 21, 2018

ahippo commented Aug 23, 2018

mgorny Aug 23, 2018

Choose a reason for hiding this comment

ahippo Aug 23, 2018

Choose a reason for hiding this comment

ahippo commented Aug 24, 2018

mgorny commented Aug 24, 2018

ahippo commented Aug 24, 2018 • edited

ahippo commented Aug 25, 2018 • edited

mgorny commented Aug 25, 2018

ahippo commented Aug 25, 2018

mgorny commented Aug 25, 2018

ahippo commented Aug 26, 2018

ahippo commented Aug 26, 2018

gentoo-repo-qa-bot commented Aug 26, 2018

mgorny commented Aug 26, 2018

ahippo commented Aug 26, 2018

ahippo commented Aug 12, 2018 •

edited

ahippo commented Aug 24, 2018 •

edited

ahippo commented Aug 25, 2018 •

edited