x11-terms/terminology unbundle lz4 and fix efl dependencies on 1.2.1 #9636
Conversation
gentoo-bot
added
self-maintained
| default | ||
| xdg_environment_reset | ||
|
|
||
| if use system-lz4 ; then |
There was a problem hiding this comment.
the patch is really tiny, apply it unconditionally
There was a problem hiding this comment.
and always use system-provided lz4 rather than bundled one? What if the build fails with system one? I wanted to apply it unconditionally but couldn't answer this question myself, so decided to make it a USE flag.
There was a problem hiding this comment.
but is there a reason to use bundled lz4? By standards and security reasons we try not to use bundled libs at all if possible. So it is better to just make sure it works and leave it with the system one.
There was a problem hiding this comment.
By standards and security reasons we try not to use bundled libs at all if possible.
I'm aware :)
My logic was, that it was probably bundled due to system lz4 causing breakages, and I didn't wish for that to happen. I'll gladly apply it unconditionally.
And I talked about this with the author in IRC, and he's getting rid of it with terminology-1.3 (https://phab.enlightenment.org/T7328)
Anyway I'll remove the USE-case and rebase this PR in a minute.
- Add patch to use system liblz4 instead of bundled one, - More accurate dependencies on dev-libs/efl to use with wayland. Closes: https://bugs.gentoo.org/648834 Package-Manager: Portage[mgorny]-2.3.43.3
Package-Manager: Portage[mgorny]-2.3.43.3
|
Pull request CI report Report generated at: 2018-08-20 13:00 UTC No issues found |
This change probably doesn't need a revbump, but to be sure I decided to do it. Terminology compiles in 30 seconds so no huge harm there (+ the USE-flag change probably makes everyone re-compile anyway).