Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-util/edb-debugger: add dev-qt/qtsvg:5 as a runtime dependency #9657

Closed
wants to merge 1 commit into from
Closed

dev-util/edb-debugger: add dev-qt/qtsvg:5 as a runtime dependency #9657

wants to merge 1 commit into from

Conversation

Petross404
Copy link
Contributor

Fixes https://bugs.gentoo.org/664188

Package-Manager: Portage-2.3.47, Repoman-2.3.10

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Aug 21, 2018
@Petross404 Petross404 changed the title dev-util/edb-debugger: add dev-qt/qtsvg:5 as a runtime dependency dev-util/edb-debugger: add dev-qt/qtsvg:5 as a runtime dependency [please reassign] Aug 21, 2018
@gentoo-bot gentoo-bot changed the title dev-util/edb-debugger: add dev-qt/qtsvg:5 as a runtime dependency [please reassign] dev-util/edb-debugger: add dev-qt/qtsvg:5 as a runtime dependency Aug 21, 2018
@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-util/edb-debugger

dev-util/edb-debugger: @Petross404, @gentoo/proxy-maint

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Aug 21, 2018
a17r
a17r suggested changes Aug 21, 2018
View reviewed changes
Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RDEPEND change requires a revbump.

dev-util/edb-debugger/edb-debugger-1.0.0.ebuild Outdated
@@ -19,13 +19,14 @@ S="${WORKDIR}/${P}"
RDEPEND="
dev-libs/capstone
graphviz? ( media-gfx/graphviz )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the opportunity to properly sort these lines (optional deps below unconditional)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do tomorrow unfortunately, no more time now. I am afraid I did not quite understand what you want me to do with "put optional deps below unconditional".

Thank you.

Also, a rev bump requires a rX, where X is the revision number?

@a17r
Copy link
Member

a17r commented Aug 26, 2018 •
edited

Fixes https://bugs.gentoo.org/664188

^ gentoo-bot does not understand that input. If you want to have the bug closed by your commit, use the Closes: tag.

@a17r
Copy link
Member

a17r commented Aug 26, 2018

I see you have S="${WORKDIR}/${P}" in the ebuild, but this is not necessary. It is the standard value.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-08-26 11:17 UTC
Newest commit scanned: eb13d22
Status: ✅ good

No issues found

@Petross404
Copy link
Contributor Author

@a17r Nice, didn't know the reason it is required. Now for the other variable, I have no idea how it got there and why I haven't deleted this. I can open another pr, besides it doesn't have to be rev bumped, so the users won't get annoyed by the constant update of the ebuilds.

Thank you for your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a17r a17r a17r approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@Petross404 @gentoo-bot @a17r @gentoo-repo-qa-bot