Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-misc/radeontop: move package, version/EAPI bump, take maintainership #9673

Closed
wants to merge 4 commits into from
Closed

app-misc/radeontop: move package, version/EAPI bump, take maintainership #9673

wants to merge 4 commits into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented Aug 23, 2018

Hi,

I'm requesting for maintainership of x11-apps/radeontop. The package is currently maintainer-needed.
With this PR i did following changes:

  • move package from x11-apps/radeontop to app-misc/radeontop, fixes bug https://bugs.gentoo.org/571848 - i've decided to use app-misc for the package, please let me know if a other category fits better.
  • version bump, there is already a version 1.1 out for some time
  • EAPI7 bump for the 9999 version
  • adding myself as the maintainer of the package.

There is still one problem which i don't know how to fix:

 * QA Notice: The following shared libraries lack a SONAME
 * /usr/lib64/libradeontop_xcb.so

Some advice here would be great, otherwise this is not a regression, as the actual package has the problem too.

Please review.

@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds, profiles
Packages affected: app-misc/radeontop, x11-apps/radeontop

app-misc/radeontop: @gentoo/proxy-maint (new package)
x11-apps/radeontop: @gentoo/proxy-maint (maintainer needed)

Bugs linked: 571848

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 23, 2018
@mgorny
Copy link
Member

mgorny commented Aug 23, 2018

Does it require or use X11?

mgorny
mgorny requested changes Aug 23, 2018
View reviewed changes
app-misc/radeontop/radeontop-1.1.ebuild Outdated
default

cat > include/version.h <<-EOF || die
#ifndef VER_H
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the contents, please.

app-misc/radeontop/radeontop-9999.ebuild
@@ -1,7 +1,7 @@
# Copyright 1999-2017 Gentoo Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add version to commit message prefix; make it match the directory instead. Instead, mention it in the summary.

@mm1ke
Copy link
Contributor Author

mm1ke commented Aug 23, 2018

@mgorny
No it doesn't require X11, it works similar to htop but only for the amd graphic cards. I also test compiled it on a X11-less system without a problem.

@mgorny
Copy link
Member

mgorny commented Aug 23, 2018

Thanks. I'm going to merge now.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-08-23 19:56 UTC
Newest commit scanned: 994e03a
Status: ✅ good

No issues found

@ShadowsFriend
Copy link
Contributor

@mm1ke: The missing soname is an upstream issue. I have opened a pull request[1] to address it.

[1] clbr/radeontop#75

@mm1ke mm1ke deleted the radeontop-JNcfgD3M branch January 29, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can. new package The PR is adding a new package.
Projects
None yet
Milestone
No milestone
5 participants
@mm1ke @gentoo-bot @mgorny @gentoo-repo-qa-bot @ShadowsFriend