Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-backup/rear: bump to v2.4 #9680

Closed
wants to merge 1 commit into from
Closed

app-backup/rear: bump to v2.4 #9680

wants to merge 1 commit into from

Conversation

teissler
Copy link
Contributor

Closes: https://bugs.gentoo.org/664004

Signed-off-by: Timo Eissler morlix@morlix.de

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 24, 2018
@mgorny
Copy link
Member

mgorny commented Aug 25, 2018

I'm afraid I can't test it right now. Could you ping me when the download location works again?

>>> Downloading 'https://download.sourceforge.net/project/rear/rear/2.4/rear-2.4.tar.gz'
--2018-08-25 08:06:42--  https://download.sourceforge.net/project/rear/rear/2.4/rear-2.4.tar.gz
Resolving download.sourceforge.net (download.sourceforge.net)... 52.85.131.174, 52.85.131.81, 52.85.131.254, ...
Connecting to download.sourceforge.net (download.sourceforge.net)|52.85.131.174|:443... connected.
GnuTLS: A TLS fatal alert has been received.
GnuTLS: received alert [40]: Handshake failed
Unable to establish SSL connection.
!!! Couldn't download 'rear-2.4.tar.gz'. Aborting.

@teissler
Copy link
Contributor Author

I changed the SRC_URI to github instead of SF, please restart your tests.

@mgorny mgorny removed the assigned PR successfully assigned to the package maintainer(s). label Sep 15, 2018
@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: app-backup/rear

app-backup/rear: @teissler, @gentoo/proxy-maint

Bugs linked: 664004

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 15, 2018
mgorny
mgorny requested changes Sep 15, 2018
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delay. I've tested it now, and I see some issues reported:

 * One or more empty directories installed to /var:
 * 
 *   /var/lib
 *   /var/lib/rear
 *   /var/log
 *   /var/log/rear
 * 
 * If those directories need to be preserved, please make sure to create
 * or mark them for keeping using 'keepdir'. Future versions of Portage
 * will strip empty directories from installation image.

Furthermore, documentation should be installed to /usr/share/doc/${PF} (and not ${P}).

app-backup/rear/rear-2.4.ebuild Outdated
HOMEPAGE="http://relax-and-recover.org/"
SRC_URI="https://github.com/${PN}/${PN}/archive/${PV}.tar.gz -> ${P}.tar.gz"

LICENSE="GPL-2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about that? I've just looked at random file and it says GPL-3+.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the License.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why GPL-3 and not GPL-3+?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake sorry, i fixed it.

app-backup/rear/rear-2.4.ebuild Outdated
sys-block/parted
sys-boot/syslinux
virtual/cdrtools
udev? ( virtual/udev )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort conditions lexically too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for not being clear here. First all unconditionals, sorted, then conditions, sorted ;-).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mgorny
Copy link
Member

mgorny commented Oct 3, 2018

Also please squash your commits.

@teissler
Copy link
Contributor Author

teissler commented Oct 8, 2018

Squashed

@teissler
app-backup/rear: bump to v2.4
7e24f03 
Closes: https://bugs.gentoo.org/664004

Signed-off-by: Timo Eissler <morlix@morlix.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-10-09 13:39 UTC
Newest commit scanned: 7e24f03
Status: ✅ good

No issues found

mgorny
mgorny approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'm sorry this took so long. I'll merge it now.

@gentoo-bot gentoo-bot closed this in c787c88 Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@teissler @mgorny @gentoo-bot @gentoo-repo-qa-bot