media-video/obs-studio: Various updates. #9689
Conversation
gentoo-bot
added
self-maintained
|
Updated with the bump to be for version 22.0.2 instead of 22.0.1. |
| @@ -6,7 +6,7 @@ EAPI=6 | |||
| PYTHON_COMPAT=( python{3_4,3_5,3_6} ) | |||
| CMAKE_MIN_VERSION=3.9.6 | |||
There was a problem hiding this comment.
3.9.6 is current default in cmake-utils.eclass so this line could be dropped
There was a problem hiding this comment.
Dropped it shall be.
| @@ -3,9 +3,10 @@ | |||
|
|
|||
| EAPI=6 | |||
|
|
|||
| PYTHON_COMPAT=( python{3_4,3_5,3_6} ) | |||
There was a problem hiding this comment.
could you check if it may be fine with python3_7 already?
There was a problem hiding this comment.
I forget why I didn't go for it before, but regardless, it looks like only 3.6 is officially supported (while things may work on other versions as well).
That's based on a chat in the upstream IRC channel.
The documentation [1] I was going by only mentioned 3.6 being required for Windows, and I couldn't see/find any issues with the versions we had at the time, so I added all three.
| pulseaudio? ( media-sound/pulseaudio ) | ||
| python? ( ${PYTHON_DEPS} ) | ||
| speexdsp? ( media-libs/speexdsp ) |
There was a problem hiding this comment.
Please switch to USE=speex here, which is used elsewhere in tree already.
There was a problem hiding this comment.
This I also considered when adding it, but the Speex DSP, and its purpose here seemed to be different enough from Speex. I can certainly go with 'speex' instead, however.
There was a problem hiding this comment.
Yes please. speexdsp and speex are two parts of the same software, and while they are independently packaged for some time now, there is no reason to follow through with more use flag granularity as well.
|
Changes:
|
Are you sure it does not work with 3.5? Because that change may end up some people with conflicts on upgrade. I tend to 'keep it if there's no bug report'. |
Not at all. I've heard no reports of it not working, and as such, was indeed wondering which would be the better way forward. I'll change it back. Thanks! |
Since FFmpeg 4 is still masked, depending on a USE-flag specific to that version is a QA violation, so for now only the 9999 version will be compatible with it. Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> Package-Manager: Portage-2.3.48, Repoman-2.3.10
Previously, the fact that 'python-any-r1.eclass' is intended for build-time dependent packages only was completely missed, while Python is required at run-time when used for OBS Studio scripting. Closes: https://bugs.gentoo.org/662702 Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> Package-Manager: Portage-2.3.48, Repoman-2.3.10
Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> Package-Manager: Portage-2.3.49, Repoman-2.3.10
The use of the flag is similar enough to the existing one. Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> Package-Manager: Portage-2.3.49, Repoman-2.3.10
Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> Package-Manager: Portage-2.3.48, Repoman-2.3.10
Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> Package-Manager: Portage-2.3.48, Repoman-2.3.10
Closes: https://bugs.gentoo.org/665766 Signed-off-by: Jimi Huotari <chiitoo@gentoo.org> Package-Manager: Portage-2.3.49, Repoman-2.3.10
Pull request CI reportReport generated at: 2018-10-04 14:16 UTC No issues found |
Not sure how the QA issue didn't come up last time (maybe something changed in repoman... did not check a look).
Let's see if gentoo-repo-qa-bot yells at me again when doing the Python thingies like so...