New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-util/btyacc: EAPI7 revbump, improve ebuild #9692
Conversation
Pull Request assignment Areas affected: ebuilds dev-util/btyacc: At least one of the listed packages is maintained entirely by non-GitHub developers! Bugs linked: 664546 In order to force reassignment and/or bug reference scan, please append |
dev-util/btyacc/btyacc-3.0-r3.ebuild
Outdated
|
||
inherit toolchain-funcs | ||
|
||
MY_P=${P/./-} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not use bashizm here
|
||
src_compile() { | ||
tc-export CC | ||
emake CC=$(tc-getCC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this alone should be probably enough
dev-util/btyacc/btyacc-3.0-r3.ebuild
Outdated
"${FILESDIR}/${P}-includes.patch" | ||
"${FILESDIR}/${P}-makefile.patch" | ||
) | ||
DOCS=( README README.BYACC ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, just dodoc, do not increase complexity for nothing
db7cffa
to
b37d8e9
Compare
21bfaab
to
b41e70d
Compare
b41e70d
to
4111bd0
Compare
Closes: https://bugs.gentoo.org/664546 Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger@gmail.com>
0247097
to
50dcdaa
Compare
ping, any chance we can merge this :) |
Pull request CI reportReport generated at: 2019-02-08 20:59 UTC No issues found |
Hi,
This PR/Bug updates dev-util/btyacc for EAPI7.
Please review
Closes: https://bugs.gentoo.org/664546