games-rpg/baldurs-gate-ee: bump to 2.5.23121 #9747
Conversation
|
Pull Request assignment Areas affected: ebuilds games-rpg/baldurs-gate-ee: @diogocp, @gentoo/proxy-maint No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment. In order to force reassignment and/or bug reference scan, please append |
gentoo-bot
added
self-maintained
|
|
||
| inherit eutils unpacker | ||
| inherit desktop eutils unpacker |
There was a problem hiding this comment.
Please drop eutils and unpacker (you can drop probably src_unpack() as well?)
There was a problem hiding this comment.
eutils is required for make_wrapper.
Without unpacker the file is not recognized. With unpacker but no explicit unpack_zip, unpacking fails. I could use unzip directly, but unpack_zip seems better. This was also discussed before.
| media-libs/openal[abi_x86_32(-)] | ||
| virtual/opengl[abi_x86_32(-)] | ||
| x11-libs/libX11[abi_x86_32(-)]" | ||
| RDEPEND="dev-libs/expat |
There was a problem hiding this comment.
aren't you missing [${MULTILIB_USEDEP}] on all those?
There was a problem hiding this comment.
I don't think that is necessary. This new version includes both x86 and amd64 binaries.
There was a problem hiding this comment.
but then you need to make sure that the dependencies are built for these ABIs as well?
There was a problem hiding this comment.
I don't want this package to have "multilib" support. It's an application, so I only want to install it for the native ABI. AFAIK the native ABI is implied in dependency specifications that do not explicitly specify another one.
There was a problem hiding this comment.
ah, yeah. I misinterpreted your previous message, but the ebuild code makes it clear anyway.
Package-Manager: Portage-2.3.49, Repoman-2.3.10
diogocp
force-pushed
the
baldurs-gate-ee
branch
from
f0650aa
to
40ff633
Compare
|
I kept the old version for now. |
Pull request CI reportReport generated at: 2018-09-21 12:16 UTC No issues found |
No description provided.