Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-dns/ddclient: fix systemd unit #9773

Closed
wants to merge 1 commit into from
Closed

net-dns/ddclient: fix systemd unit #9773

wants to merge 1 commit into from

Conversation

ConiKost
Copy link
Contributor

@ConiKost ConiKost commented Sep 3, 2018

Closes: https://bugs.gentoo.org/665150
Package-Manager: Portage-2.3.48, Repoman-2.3.10

@gentoo-bot
Copy link

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-dns/ddclient

net-dns/ddclient: @titanofold, @ConiKost, @gentoo/proxy-maint

Bugs linked: 665150

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 3, 2018
@titanofold titanofold self-assigned this Sep 3, 2018
titanofold
titanofold suggested changes Sep 3, 2018
View reviewed changes
Copy link
Member

@titanofold titanofold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the whole systemd unit (issues from PR #9762) instead of just this one thing.

Also, avoid mkdir -p as it doesn't complain if something doesn't get made.

@ConiKost ConiKost force-pushed the ddclient branch 2 times, most recently from 8e853f8 to d5836d3 Compare September 3, 2018 17:55
@ConiKost
Copy link
Contributor Author

ConiKost commented Sep 3, 2018 •
edited

Let's fix the whole systemd unit (issues from PR #9762) instead of just this one thing.

Yep. Please have a look, I've created now tmpfiles for systemd, which should be more elegant than those chmod stuff in the unit file itself. Added also keepdir.

@ConiKost ConiKost force-pushed the ddclient branch 2 times, most recently from 18e5c0c to 357df6c Compare September 3, 2018 18:11
@ConiKost ConiKost changed the title net-dns/ddclient: fix path in systemd unit net-dns/ddclient: fix systemd unit Sep 3, 2018
titanofold
titanofold suggested changes Sep 3, 2018
View reviewed changes
Copy link
Member

@titanofold titanofold left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. And some extra things I didn't notice yesterday in my excitement about someone working on this.

net-dns/ddclient/ddclient-3.9.0-r1.ebuild Outdated
src_install() {
dobin ddclient

newinitd "${FILESDIR}"/ddclient.initd-r5 ddclient
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

net-dns/ddclient/ddclient-3.9.0-r1.ebuild Outdated

diropts -o ddclient -g ddclient
keepdir /var/cache/ddclient
diropts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keepdir section is unnecessary.

Now that we're going to have a fancy tmpfiles.d, it should be created at run time by systemd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I wasn't sure, if keepdir shouldn't be as some sort of a backup. Anyway, removed now again.

net-dns/ddclient/ddclient-3.9.0-r1.ebuild Outdated
diropts

newinitd "${FILESDIR}"/ddclient.initd-r5 ddclient
systemd_dounit "${FILESDIR}"/ddclient.service
Copy link
Member

@titanofold titanofold Sep 3, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to install the old revision of ddclient.service?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, fixed.

@ConiKost
net-dns/ddclient: fix systemd unit
88a94de 
Closes: https://bugs.gentoo.org/665150
Package-Manager: Portage-2.3.48, Repoman-2.3.10
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-09-03 19:18 UTC
Newest commit scanned: 88a94de
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/ec092ee/output.html#media-plugins/vdr-pvr350

@gentoo-bot gentoo-bot closed this in 8731f58 Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titanofold titanofold titanofold approved these changes

Assignees

@titanofold titanofold

Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@ConiKost @gentoo-bot @gentoo-repo-qa-bot @titanofold