dev-python/pandas-datareader: new package

[TheChymera]

Package-Manager: Portage-2.3.49, Repoman-2.3.10

[gentoo-bot]

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-python/pandas-datareader

dev-python/pandas-datareader: @gentoo/proxy-maint (new package)

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

[mgorny]

E   ImportError: No module named wrapt

when running tests.

[mgorny]

That's just calling pytest. Inline it, and make it verbose.

[mgorny]

Erm, variable assignments don't work backwards, yes? ;-P

[TheChymera]

@mgorny ok now?

[mgorny]

Ok, I'll build the other pandas version now ;-).

[mgorny]

>>> Test phase: dev-python/pandas-datareader-0.7.0
 * python2_7: running distutils-r1_run_phase python_test
=============================================================== test session starts ===============================================================
platform linux2 -- Python 2.7.15, pytest-3.8.0, py-1.5.4, pluggy-0.7.1
rootdir: /tmp/portage/dev-python/pandas-datareader-0.7.0/work/pandas-datareader-0.7.0, inifile:
plugins: mock-1.10.0

========================================================== no tests ran in 0.01 seconds ===========================================================
ERROR: file not found: xX

Also, pytest is the new way of calling pytest.

[TheChymera]

@mgorny ok

[mgorny]

============================== 68 failed, 19 passed, 58 skipped, 40 xfailed, 1 xpassed, 8 warnings in 84.62 seconds ===============================

dev-python:pandas-datareader-0.7.0:20180928-083840.log

[TheChymera]

@mgorny these look like all of the same error:

ConnectionError: 

Which I never got. It sounds like the test suite attempts to connect to the internet (which is what the package does as its functionality), and you are testing it on a machine without outward connection. Is that true?

[TheChymera]

@mgorny I was able to confirm. The errors you are getting stem from your system's network connectivity issues. The package is otherwise ok. Can we merge now?

[mgorny]

Read the big section on how Internet access is forbidden and lets users send Internet bills over to you: https://devmanual.gentoo.org/ebuild-writing/functions/src_test/index.html

[TheChymera]

@mgorny ok, I had a alook at other ebuilds and I can't figure out what best to do. Do I:

1. RESTRICT="test"
2. sed/rm all of the network bits out (which is more than half the test suite)
3. sed/rm all of the network bits out only if has network-sandbox ${FEATURES}

?

[mgorny]

1 or 2. Figure out how useful the suite is without Internet. Also file a request upstream to consider mocking/replay-based tests since using Internet services is unreliable at best.

[TheChymera]

The test suite is not particularly useful without internet connectivity, since this is what the package does, read data from the internet. Upstream seems uninterested in solving the issue: pydata/pandas-datareader#586

So I have moved to restrict testing.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2018-10-01 00:59 UTC
Newest commit scanned: 41bc843
Status: ✅ good

No issues found

[mgorny]

Thanks. I have verified that all but two Yahoo tests consistently pass on all impls. I'll merge now.