Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail-client/alpine: fix file name #9911

Closed
wants to merge 1 commit into from
Closed

mail-client/alpine: fix file name #9911

wants to merge 1 commit into from

Conversation

robert7k
Copy link
Contributor

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Sep 19, 2018
@robert7k robert7k changed the title mail-client/alpine: fix file name mail-client/alpine: fix file name [please reassign] Sep 19, 2018
@gentoo-bot gentoo-bot changed the title mail-client/alpine: fix file name [please reassign] mail-client/alpine: fix file name Sep 19, 2018
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: mail-client/alpine

mail-client/alpine: @robert7k, @gentoo/net-mail, @gentoo/proxy-maint

Linked bugs

Bugs linked: 666490

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Sep 19, 2018
mgorny
mgorny requested changes Sep 19, 2018
View reviewed changes
mail-client/alpine/Manifest Outdated
@@ -1,3 +1,4 @@
DIST 2.21.1-r1.tar.gz 7490140 BLAKE2B 13ac5ef43dd729a7cf21b44dcd6feace3e1813672aec537fd05d5ff90b67bec145ceef71cfcf35b0cb7e250bb307556f5dcf8ebb024bc6366fd0ace0a7c41161 SHA512 106caa7bfe86fd5e82554ba68b9ee579cd8495bcd0dfbf82d9d75da2df3bd292d42d67af8ec737091f2a820b2555c25bbf0058c9c7bb5de5f950b570ffc25c4d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a friendly or safe distfile name. It's asking for accidental collisions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint, I fixed that.

mgorny
mgorny reviewed Sep 21, 2018
View reviewed changes
mail-client/alpine/alpine-2.21.1-r1.ebuild Outdated
@@ -7,8 +7,7 @@ inherit autotools toolchain-funcs vcs-snapshot
DESCRIPTION="An easy to use text-based based mail and news client"
HOMEPAGE="http://www.washington.edu/alpine/ http://repo.or.cz/alpine.git/"
GIT_COMMIT="843b2f16abfd949e09b1c5465387b1b0f724994a"
SRC_URI="http://repo.or.cz/alpine.git/snapshot/${GIT_COMMIT}.tar.gz -> ${P}.tar.gz"
RESTRICT="mirror"
SRC_URI="http://repo.or.cz/alpine.git/snapshot/${GIT_COMMIT}.tar.gz -> ${PF}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PF is no good here. It means that when someone revbumps it (e.g. due to dep change), he'll suddenly change filename for no reason.

Also, please match the upstream name, i.e. alpine-843b2f1 (grab it off ${GIT_COMMIT::n} where n is some number), and use that both for -> name and S; then remove vcs-snapshot as that eclass is deprecated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out, I fixed it accordingly.

@robert7k
mail-client/alpine: fix file name
7ebb151 
Closes: https://bugs.gentoo.org/666490

Signed-off-by: Robert Siebeck <gentoo.bugzilla.2012@r123.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-09-24 01:38 UTC
Newest commit scanned: 7ebb151
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/7b66963/output.html#app-crypt/hashcat-utils

mgorny
mgorny approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I'll test just to be sure, and merge.

@robert7k robert7k deleted the alpine branch September 25, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@robert7k @gentoo-bot @gentoo-repo-qa-bot @mgorny