New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-scheme/gambit: add USE libressl #9929
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentAreas affected: ebuilds dev-scheme/gambit: @gentoo/scheme Linked bugsBugs linked: 666629 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Hi, thanks for the patch but it has to be revbumped to unstable so gambit-4.8.8-r2 and unstable keywords. Thanks |
@Amynka, are you sure? This change does not make any difference to systems with the package already installed. No patches are added, no substantial changes it the ebuild are made, just a simple adding of a flag. Why shouldn't it be done in the same revision? |
@steils we always change the revision and keywords status (stable -> unstable) when we add something new what stable users currently have no, it is the only way users can be aware of the changes. |
As I said it is stable and you cannot make such a changes to stable package therefor it has to be revbumped to unstable where the change can be made. |
Mikle, Amy, thanks for the explanation. I have revbumped the ebuild. Yet...
I doubt that it is always: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4582b31ed2cf4323040ccea113a59009ce46fb06 and there are other examples. Maybe it's worth to write in devmanual explicitly that changing revisions for stable packages is required? Here: https://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html |
It is not common
This is obvious. |
Closes: https://bugs.gentoo.org/666629 Package-Manager: Portage-2.3.49, Repoman-2.3.10 Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
Pull request CI reportReport generated at: 2018-12-06 11:18 UTC Issues already there before the PR (double-check them): |
Closes: https://bugs.gentoo.org/666629 Package-Manager: Portage-2.3.49, Repoman-2.3.10 Closes: gentoo#9929 Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com> Signed-off-by: Amy Liffey <amynka@gentoo.org>
Closes: https://bugs.gentoo.org/666629
Package-Manager: Portage-2.3.49, Repoman-2.3.10
Signed-off-by: Stefan Strogin stefan.strogin@gmail.com