Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-scheme/gambit: add USE libressl #9929

Closed
wants to merge 1 commit into from
Closed

Conversation

steils
Copy link
Member

@steils steils commented Sep 20, 2018

Closes: https://bugs.gentoo.org/666629
Package-Manager: Portage-2.3.49, Repoman-2.3.10
Signed-off-by: Stefan Strogin stefan.strogin@gmail.com

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-scheme/gambit

dev-scheme/gambit: @gentoo/scheme

Linked bugs

Bugs linked: 666629


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 20, 2018
@Amynka
Copy link
Contributor

Amynka commented Oct 27, 2018

Hi, thanks for the patch but it has to be revbumped to unstable so gambit-4.8.8-r2 and unstable keywords. Thanks

@Amynka Amynka self-assigned this Oct 27, 2018
@steils
Copy link
Member Author

steils commented Oct 28, 2018

@Amynka, are you sure? This change does not make any difference to systems with the package already installed. No patches are added, no substantial changes it the ebuild are made, just a simple adding of a flag. Why shouldn't it be done in the same revision?

@Zlogene
Copy link
Contributor

Zlogene commented Oct 28, 2018

@steils we always change the revision and keywords status (stable -> unstable) when we add something new what stable users currently have no, it is the only way users can be aware of the changes.

@Amynka
Copy link
Contributor

Amynka commented Oct 28, 2018

As I said it is stable and you cannot make such a changes to stable package therefor it has to be revbumped to unstable where the change can be made.

@steils
Copy link
Member Author

steils commented Oct 28, 2018

Mikle, Amy, thanks for the explanation.

I have revbumped the ebuild.

Yet...

we always change the revision and keywords status (stable -> unstable) when we add something new what stable users currently have no, it is the only way users can be aware of the changes

I doubt that it is always: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4582b31ed2cf4323040ccea113a59009ce46fb06 and there are other examples.

Maybe it's worth to write in devmanual explicitly that changing revisions for stable packages is required? Here: https://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html
For now it's written a little differently.

@Zlogene
Copy link
Contributor

Zlogene commented Oct 29, 2018

I doubt that it is always: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4582b31ed2cf4323040ccea113a59009ce46fb06 and there are other examples.

It is not common

Maybe it's worth to write in devmanual explicitly that changing revisions for stable packages is required?

This is obvious.

Closes: https://bugs.gentoo.org/666629
Package-Manager: Portage-2.3.49, Repoman-2.3.10
Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-12-06 11:18 UTC
Newest commit scanned: e8e575f
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/712a77e/output.html#sys-apps/dtc

anaveragehuman pushed a commit to anaveragehuman/gentoo that referenced this pull request Jan 4, 2019
Closes: https://bugs.gentoo.org/666629
Package-Manager: Portage-2.3.49, Repoman-2.3.10
Closes: gentoo#9929
Signed-off-by: Stefan Strogin <stefan.strogin@gmail.com>
Signed-off-by: Amy Liffey <amynka@gentoo.org>
@steils steils deleted the gambit branch February 13, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants