dev-libs/ucommon: Fix building with GCC-7 and GCC8

[Peter-Levine]

Signed-off-by: Peter Levine plevine457@gmail.com
Closes: https://bugs.gentoo.org/638252
Package-Manager: Portage-2.3.49, Repoman-2.3.10

Most of the errors are a result of overload resolution failure caused by a const qualified method trying to call a non-const qualified, inherited method. One way to resolve it is to remove const qualification from the calling method. The other is to add const qualification to the called method. Attempting to add const qualification, in the latter case, resulted in many more failures as many other parts of the code were dependent on the non-const method. Removing the const qualification, in the former case, resulted in build success.

Also, for GCC-8, static_cast cannot be used to cast a pointer of a pointer of an object to a pointer of a pointer of a different object. reinterpret_cast works fine though.

Note: I initially attempted to make an EAPI 7 build, changing dependence on autotools-utils.eclass to autotools.eclass, but any EAPI above 5 causes the aclocal -I m4 command in eaclocal to fail for some unknown reason.

[gentoo-bot]

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-libs/ucommon

dev-libs/ucommon: @maksbotan

Linked bugs

Bugs linked: 638252

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[Peter-Levine]

Disregard. Didn't see it was fixed in 7.0.0 and there is a bump request.