Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/cargo: update openssl-sys crate to 0.9.46 for libressl 2.9.1 #293

Closed
wants to merge 1 commit into from
Closed

Conversation

CaseOf
Copy link
Collaborator

@CaseOf CaseOf commented May 7, 2019

Hello,
I updated openssl-sys crate to make cargo successfully built with libressl 2.9.1.

@steils
Copy link
Member

steils commented May 8, 2019

Fails to compile with:

>>> Compiling source in /var/tmp/portage/dev-util/cargo-0.30.0-r1/work/cargo-0.30.0 ...
error: no matching package named `autocfg` found
location searched: registry `https://github.com/rust-lang/crates.io-index`
required by package `openssl-sys v0.9.45`
    ... which is depended on by `curl v0.4.17`
    ... which is depended on by `crates-io v0.18.0`
    ... which is depended on by `cargo v0.30.0 (file:///var/tmp/portage/dev-util/cargo-0.30.0-r1/work/cargo-0.30.0)`
 * ERROR: dev-util/cargo-0.30.0-r1::libressl failed (compile phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line 124:  Called src_compile
 *   environment, line 2164:  Called die
 * The specific snippet of code:
 *       ${cargo} build -j$(makeopts_jobs) --release || die;

@CaseOf
Copy link
Collaborator Author

CaseOf commented May 8, 2019

I added autocfg to crates list

@steils
Copy link
Member

steils commented May 9, 2019

Thanks, but... Have you tried to build it with libressl 2.9.1?

error: failed to run custom build command for `openssl-sys v0.9.45`
(...)
cargo:rustc-cfg=libressl
cargo:rustc-cfg=libressl251
cargo:rustc-cfg=libressl261
cargo:rustc-cfg=libressl270
cargo:rustc-cfg=libressl273
cargo:rustc-cfg=libressl280
cargo:rustc-cfg=libressl281
cargo:libressl_version_number=2090100f

--- stderr
thread 'main' panicked at '

This crate is only compatible with OpenSSL 1.0.1 through 1.1.1, or LibreSSL 2.5
through 2.9.0, but a different version of OpenSSL was found. The build is now aborting
due to this version mismatch.

', /var/tmp/portage/dev-util/cargo-0.30.0-r1/work/cargo_home/gentoo/openssl-sys-0.9.45/build/main.rs:238:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

openssl-sys-0.9.46 is needed to support LibreSSL 2.9.1. It was released 2 hours ago though. Before that a patch was needed to make openssl-sys compile with Libressl 2.9.1, probably something like this: https://cgit.gentoo.org/repo/gentoo.git/commit/?id=b327798c4d14398f0a1f55140cf95241fb5aeda0

And if you upgrade "openssl-sys" crate, you need to upgrade "openssl" crate too.

I shall amend the change and push it.

Signed-off-by: Quentin Retornaz <gentoo@retornaz.com>
Package-Manager: Portage-2.3.62, Repoman-2.3.11
@CaseOf
Copy link
Collaborator Author

CaseOf commented May 9, 2019

updated to openssl-sys 0.9.46 then

@CaseOf CaseOf changed the title dev-util/cargo: update openssl-sys crate to 0.9.45 for libressl 2.9.1 dev-util/cargo: update openssl-sys crate to 0.9.46 for libressl 2.9.1 May 9, 2019
@gentoo-bot gentoo-bot closed this in bf14a41 May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants