Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic rendering tests with tox #18

Closed
wants to merge 3 commits into from

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Nov 7, 2023

Hello,

I believe it would be nice to have at least some basic rendering tests for pambase. So here it is :-)
There is a bit related bug: https://bugs.gentoo.org/916869

I realize this is a mirror repository, but I'm not sure if there's a better way to propose these changes.

Best regards!

Signed-off-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
@thesamesam
Copy link
Member

Big thanks for doing this. I've been nervous about touching pambase because it's so hard to verify the stability of results, which is of course critical because PAM's rules are line-order based.

Would you consider adding a basic github action rule to run tox?

These changes enable tests on the GitHub side.
The implementation relies on Official Gentoo Docker images,
since I believe it's a better way to test Gentoo-specific packages.

Useful links:
  * https://www.gentoo.org/news/2020/07/04/official-docker.html
  * https://github.com/gentoo/gentoo-docker-images
  * https://github.com/docker/build-push-action
  * https://docs.docker.com/build/ci/github-actions/cache/
@Jamim
Copy link
Contributor Author

Jamim commented Nov 8, 2023

I've committed changes those enable tests on the GitHub side.
The implementation relies on Official Gentoo Docker images, since I believe it's a better way to test Gentoo-specific packages.

A workflow outcome sample might be reviewed here:
https://github.com/Jamim/pambase/actions/runs/6800065146/job/18487784920

Useful links:

@Jamim
Copy link
Contributor Author

Jamim commented Nov 8, 2023

By the way, I've found there supposed to be gentoo/python images.
They would be quite useful for this PR, but I can't find them on Docker Hub.

cc @mgorny

@thesamesam
Copy link
Member

Thank you again!

@Jamim Jamim deleted the feature/rendering-tests branch November 13, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants