_emerge: use binpkg coloring for pkg_pretend #1093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
force-pushed
the
color
branch
5 times, most recently
from
9342c08
to
6bb680e
Compare
mgorny
reviewed
Sep 15, 2023
thesamesam
force-pushed
the
color
branch
2 times, most recently
from
0a3d5ec
to
3e36079
Compare
For the 'Running pre-merge checks' message, we write: ``` >>> Running pre-merge checks for X ``` X is currently always in green, while the emerge list above might have the atom X listed in purple if it's a binpkg. Change X to be colored based on if it's a binpkg or not. Bug: https://bugs.gentoo.org/914159 Signed-off-by: Sam James <sam@gentoo.org>
Bug: https://bugs.gentoo.org/914159 Signed-off-by: Sam James <sam@gentoo.org>
With the 'echo' elog module, we get messages like: ``` * Messages for package X * Log file: /var/log/portage/build/[...] ``` Colorize 'X' based on whether it's a binpkg or not, rather than always using green as if it was built from source. Bug: https://bugs.gentoo.org/914159 Signed-off-by: Sam James <sam@gentoo.org>
mgorny
approved these changes
Sep 15, 2023
|
Yeah, I was wondering the same. I'll leave it for now though. Thanks! |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the 'Running pre-merge checks' message, we write:
X is currently always in green, while the emerge list above might have the atom X listed in purple if it's a binpkg.
Change X to be colored based on if it's a binpkg or not.
Bug: https://bugs.gentoo.org/914159