process.spawn: add abstraction layer for os.fork() #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because os.register_at_fork is used instead of multiprocessing.util.register_after_fork since commit cc7c401, we can rely on the _ForkWatcher hook being automatically invoked after os.fork(). Signed-off-by: Zac Medico <zmedico@gentoo.org>
zmedico
force-pushed
the
bug_916566_proc_cloning_abstraction
branch
2 times, most recently
from
985f244
to
296b8eb
Compare
Since os.fork() is unsafe in threaded processes, add a basic abstraction layer that will ultimately allow support of other process cloning implementations. Usage of os.fork() is now wrapped in a _start_fork function which can easily be replaced with an alternative implementation. This function takes target, args, and kwargs arguments which are equivalent to the corresponding multiprocessing.Process parameters. It also has fd_pipes and close_fds parameters, since implementation of these is dependent on the process cloning implementation. The process cloning implementation does not need to be bothered with the details of the _exec function, since spawn uses an _exec_wrapper function as a target function which calls _exec and handles any exceptions appropriately (special exception handling is required for success of test_spawnE2big related to bug 830187). Bug: https://bugs.gentoo.org/916566 Signed-off-by: Zac Medico <zmedico@gentoo.org>
zmedico
force-pushed
the
bug_916566_proc_cloning_abstraction
branch
from
296b8eb
to
7ec7a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since os.fork() is unsafe in threaded processes, add a basic
abstraction layer that will ultimately allow support of other process
cloning implementations.
Usage of os.fork() is now wrapped in a _start_fork function which can
easily be replaced with an alternative implementation. This function
takes target, args, and kwargs arguments which are equivalent to
the corresponding multiprocessing.Process parameters. It also has
fd_pipes and close_fds parameters, since implementation of these is
dependent on the process cloning implementation.
The process cloning implementation does not need to be bothered with
the details of the _exec function, since spawn uses an _exec_wrapper
function as a target function which calls _exec and handles any
exceptions appropriately (special exception handling is required for
success of test_spawnE2big related to bug 830187).
Bug: https://bugs.gentoo.org/916566