config.environ: always strip slash from SYSROOT (bug 654600) #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmedico
force-pushed
the
bug_654600_empty_sysroot
branch
2 times, most recently
from
1685b13
to
d2ac79d
Compare
|
Fair enough. @mgorny might want to add his 2¢ here as he added the stripping. |
|
Well, I just wanted to have the conditions consistent. Given that there are no EAPIs that define SYSROOT and have trailing slash, it is not strictly necessary to do it conditionally. |
zmedico
force-pushed
the
bug_654600_empty_sysroot
branch
from
d2ac79d
to
c53550a
Compare
Since SYSROOT=/ interacts badly with autotools.eclass (bug 654600), and no EAPI expects SYSROOT to have a trailing slash, always strip the trailing slash from SYSROOT. Bug: https://bugs.gentoo.org/654600 Fixes: a41dacf ("Export SYSROOT and ESYSROOT in ebuild env in EAPI 7") Reviewed-by: James Le Cuirot <chewi@gentoo.org> Reviewed-by: Michał Górny <mgorny@gentoo.org> Reviewed-by: Brian Dolbec <dolsen@gentoo.org>
zmedico
force-pushed
the
bug_654600_empty_sysroot
branch
from
c53550a
to
1b51105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SYSROOT=/ interacts badly with autotools.eclass (bug 654600),
and no EAPI expects SYSROOT to have a trailing slash, always strip
the trailing slash from SYSROOT.
Bug: https://bugs.gentoo.org/654600
Fixes: a41dacf ("Export SYSROOT and ESYSROOT in ebuild env in EAPI 7")
@chewi