global_event_loop: use asyncio event loop (bug 654390) #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmedico
force-pushed
the
bug_654390_AsyncioEventLoop
branch
from
10a8a73
to
5873efd
Compare
For python3.4 and later, in the main process, replace portage's internal event loop with the standard library's asyncio event loop. Continue to use portage's internal event loop in subprocesses, since asyncio's event loop is not guaranteed to work well in subprocesses (see upstream python issues 22087 and 29703). An _AsyncioEventLoopPolicy class, derived from _PortageEventLoopPolicy, is needed for some unit tests that modify asyncio's event loop policy. This policy is not needed for anything other than unit testing. Portage uses asyncio's default event loop policy, and API consumers are free to use any desired event loop policy. Portage's asynchronous functions that accept a 'loop' parameter will work with any compatible asyncio.AbstractEventLoop implementation, since an internal _wrap_loop function automatically adapts the loop for internal use. Bug: https://bugs.gentoo.org/654390 Reviewed-by: Brian Dolbec <dolsen@gentoo.org> Reviewed-by: Alec Warner <antarus@gentoo.org>
zmedico
force-pushed
the
bug_654390_AsyncioEventLoop
branch
from
5873efd
to
96cc073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For python3.4 and later, in the main process, replace portage's
internal event loop with the standard library's asyncio event
loop. Continue to use portage's internal event loop in subprocesses,
since asyncio's event loop is not guaranteed to work well in
subprocesses (see upstream python issues 22087 and 29703).
An _AsyncioEventLoopPolicy class, derived from _PortageEventLoopPolicy,
is needed for some unit tests that modify asyncio's event loop policy.
This policy is not needed for anything other than unit testing. Portage
uses asyncio's default event loop policy, and API consumers are free to
use any desired event loop policy.
Portage's asynchronous functions that accept a 'loop' parameter will
work with any compatible asyncio.AbstractEventLoop implementation, since
an internal _wrap_loop function automatically adapts the loop for
internal use.
Bug: https://bugs.gentoo.org/654390