Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-qt/qtnetwork: [5.15] add patch for LibreSSL support #207

Closed
wants to merge 1 commit into from
Closed

dev-qt/qtnetwork: [5.15] add patch for LibreSSL support #207

wants to merge 1 commit into from

Conversation

steils
Copy link
Member

@steils steils commented Feb 9, 2020

Bug: https://bugs.gentoo.org/562050
Package-Manager: Portage-2.3.87, Repoman-2.3.20
Signed-off-by: Stefan Strogin steils@gentoo.org

Bug: https://bugs.gentoo.org/562050
Package-Manager: Portage-2.3.87, Repoman-2.3.20
Signed-off-by: Stefan Strogin <steils@gentoo.org>
@steils steils requested a review from Pesa February 9, 2020 14:33
@steils
Copy link
Member Author

steils commented Feb 27, 2020

@Pesa ?

@steils
Copy link
Member Author

steils commented May 27, 2020

Updated the PR for main Gentoo repository, as qt-5.15.0 was moved there: gentoo/gentoo#14494

This is still actual. Please look at it.

Copy link
Contributor

@Pesa Pesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a17r do we want to carry this in the live ebuilds too? I'm fine either way

@a17r
Copy link
Member

a17r commented May 27, 2020

for 5.15.9999 it makes sense as releases are made out of it, 5.9999 will be mostly broken by now I think

@Pesa
Copy link
Contributor

Pesa commented May 27, 2020

Right. 5.9999 should probably not even exist anymore...

@steils
Copy link
Member Author

steils commented May 28, 2020

I think applying it on 5.15.9999 (and 5.16.9999 when the time comes) will be useful to warn me if there are any incompatibilities with the upcoming Qt release, so I could update the patch in time.

@Pesa
Copy link
Contributor

Pesa commented May 28, 2020

makes sense (note: there won't be a 5.16, the next version is 6.0)

@steils
Copy link
Member Author

steils commented May 28, 2020

Yay! It already fails to apply :)
I'll fix it.

@steils
Copy link
Member Author

steils commented May 28, 2020

I have updated the patch. The incompatibility was caused by this patch: https://code.qt.io/cgit/qt/qtbase.git/commit/?h=5.15&id=1941ec43ced63a1f82ca9ddad1c71d5179c33b2d
they pushed it into 5.15 branch.

Also while my patch in Gentoo was under review, LibreSSL added and enabled by default TLS 1.3 support:) So I think I'll be able to make the patch smaller thanks to that. I'll begin working on it in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants