Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-qt/qtwaylandscanner split #250

Merged
merged 2 commits into from Mar 12, 2022
Merged

Conversation

a17r
Copy link
Member

@a17r a17r commented Feb 17, 2022

Sort of a messy split, but I did not quite know how else to do it.

Ideally we would be able to split off the compositor but that is rather tricky.

@a17r a17r requested review from Chiitoo and Pesa February 17, 2022 20:04
@Pesa
Copy link
Contributor

Pesa commented Feb 20, 2022

Sort of a messy split, but I did not quite know how else to do it.

I've seen worse ;)
But what's the reason for splitting?

@a17r
Copy link
Member Author

a17r commented Mar 7, 2022

But what's the reason for splitting?

Several revdeps do not need the full qtwayland at all, and qtwaylandscanner would be in BDEPEND analogous to wayland-scanner. Afaik barely anything makes use of qtwaylandcompositor, which would be really nice to be able to split off.

@@ -27,7 +27,9 @@ DEPEND="
x11-libs/libXcomposite
)
"
RDEPEND="${DEPEND}"
RDEPEND="${DEPEND}
=dev-qt/qtwaylandscanner-${QT5_PV}*:5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the 5.15.3 bump as a way to communicate this dependency being dropped.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped dependency and will make it part of the initial package.mask message and/or gentoo-dev mail.

dev-qt/qtwayland/qtwayland-5.15.3.9999.ebuild Outdated Show resolved Hide resolved
KEYWORDS="~amd64 ~arm ~arm64 ~hppa ~ppc ~ppc64 ~riscv ~sparc ~x86"
fi

SLOT=5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this will move to the eclass later? (related to #225)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would make sense yes.

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@gentoo-bot gentoo-bot merged commit 47117a1 into gentoo:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants