sci-mathematics/acl2: Fix sed expression, clearer books install #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix sed expression which does not execute at all * Move books down to original install location Currently, the sed expression `/5/a export ACL2_SYSTEM_BOOKS=/usr/share/acl2/books/` does not modify the acl2 executable script. The sed expression's intended behavior seems to be adding the enviroment variable `ACL2_SYSTEM_BOOKS` to the fifth line on the final script; however, no modification is made. A new sed expression must replace it, namely `5iexport ACL2_SYSTEM_BOOKS=/usr/share/acl2/books/` which accomplishes inserting the enviroment variable into the script. This enviroment variable is recommended when the books directory resides outside where the executable was built [1]. In addition, the command `doins -r books` should be moved further down for the sake of clarity. This way the src_install() function modifies the files at the top and installs them at the bottom. Also, now the command `doins -r books` is beside the other similar commands. [1] https://raw.githubusercontent.com/acl2/acl2/master/doc.lisp Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Lucas Mitrak <lucas@lucasmitrak.com>
|
This should be my last PR for acl2. I think I finally fixed everything. |
|
Another note is that the patch file for this package was submitted and accepted upstream [1] so the next version will hopefully not need it. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the sed expression
/5/a export ACL2_SYSTEM_BOOKS=/usr/share/acl2/books/does not modifythe acl2 executable script. The sed expression's intended behavior
seems to be adding the enviroment variable
ACL2_SYSTEM_BOOKSto thefifth line on the final script; however, no modification is made.
A new sed expression must replace it, namely
5iexport ACL2_SYSTEM_BOOKS=/usr/share/acl2/books/which accomplishesinserting the enviroment variable into the script. This enviroment
variable is recommended when the books directory resides outside
where the executable was built [1].
In addition, the command
doins -r booksshould be moved further downfor the sake of clarity. This way the src_install() function modifies
the files at the top and installs them at the bottom. Also, now
the command
doins -r booksis beside the other similar commands.[1] https://raw.githubusercontent.com/acl2/acl2/master/doc.lisp
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Lucas Mitrak lucas@lucasmitrak.com