-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-libs/itk: bump to 5.2.1, unbundle some deps & misc improvements #1154
Conversation
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
This looks non trivial :( Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Rebasing is preferred over merging.
Yes this is okay 👍 |
We've got some complaints from pkgcheck:
Is is possible to make this patch any smaller? Or maybe fetch it from somewhere.
|
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
No actual change to the diff. Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
I noticed that you marked the conversations as resolved, but the ebuild still is the same. Did you perhaps forget to push your changes?
Yes, I did the changes locally and have not pushed them yet.
Because while testing python3_11 support for itk, I have a build
failure, and noticed that this failure also happens to python3_{9,10}.
It built fine previously, so I'm investigating the cause of the build
failure. I updated my system, but do not know yet what exactly is the
cause. I suspect it may be llvm 13->14 as a dependency of castxml. (Btw,
it seems dev-cpp/castcml::science is now in gentoo as
dev-libs/castxml::gentoo).
|
As I suspected, it is due to the llvm version castxml is built with. The issue is reported upstream there. Not sure there is something we can do in the ebuild, except for printing a warning if llvm 14 is installed. Also itk does not seem to work with python 3.11. |
Is there a difference between We can use |
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
I'm now using I don't know where the actual issue is, and don't think putting a versionned dependency is right: it's a build time thing and after building castxml one may want to reinstall llvm 14 (I did; in fact I had llvm 14 installed while building itk). Maybe the best we can do is issuing a warning in the itk ebuild telling that castxml needs to be build with llvm<14 for itk, if built with USE=python and llvm 14 is installed. I've pushed my changes which I think addresses all comments, except for python3_11 for itk, because it doesn't build on my machine, and don't have the time to investigate. |
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Actually I've figured the python3_11 issue. All should be addressed now. |
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Signed-off-by: François-Xavier Carton <fx.carton91@gmail.com>
Awesome, Thanks 👍 There is still a problem with gdcm[vtk] where it fails to compile because it can't find some libs. Probably we need to depend on some specific flag on vtk but I haven't figured out which one yet. |
gdcm
anddcmtk::gentoo
to a common package.sci-libs/gdcm[python,vtk]
, since with both USE flags some VTK python wrapping is needed and that has changed with VTK 9).