Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sci-libs/atlas: version bump to 3.11.39 #794

Closed
wants to merge 1 commit into from
Closed

sci-libs/atlas: version bump to 3.11.39 #794

wants to merge 1 commit into from

Conversation

ngg
Copy link
Contributor

@ngg ngg commented Jun 26, 2017

Version 3.11.38 is not working on some of the 7th Gen i7 processors (for example on i7-7500U), that is fixed in 3.11.39.

Patch from upstream is required to build the shared library:
https://sourceforge.net/p/math-atlas/bugs/260/

@ngg
Copy link
Contributor Author

ngg commented Jun 26, 2017 •
edited

It is strange that the default use flags contain +deprecated -lapack -fortran but if +deprecated is set then both +lapack +fortran is required. I didn't change this behavior, but it should be fixed in a later PR, either by disabling deprecated or enabling lapack and fortran by default. (I personally prefer disabling deprecated by default).

@kiwifb
Copy link
Contributor

kiwifb commented Jun 26, 2017

You have a point about +deprecated. This is about including functions in lapack that have been deprecated for a long time and that will soon be removed. I believe those functions are still used in scipy-0.16 IIRC. So of course deprecated is non sense without lapack and lapack requires fortran.

@ngg
Copy link
Contributor Author

ngg commented Jun 26, 2017

Or another solution would be to leave the defaults as they are but remove the deprecated -> lapack dependency, so if lapack is not set then deprecated is a no-op. Building dependencies will require to set the lapack use flag manually (as now), but at least the default flags would be a valid combination.

gentoo-bot pushed a commit that referenced this pull request Jun 26, 2017
@jlec
sci-libs/atlas: Sanitize default USE combination
14c1e49 
Helps sorting out #794

Package-Manager: Portage-2.3.6-prefix, Repoman-2.3.2
Signed-off-by: Justin Lecher <jlec@gentoo.org>
@jlec
Copy link
Contributor

jlec commented Jun 26, 2017

@ngg could you please enable both fortran and lapack by default?

@jlec jlec self-requested a review June 26, 2017 20:45
jlec
jlec suggested changes Jun 26, 2017
View reviewed changes
sci-libs/atlas/atlas-3.11.39.ebuild Outdated
# Copyright 1999-2017 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2

EAPI=5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump EAPI to 6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

sci-libs/atlas/atlas-3.11.39.ebuild Outdated
LICENSE="BSD"
SLOT="0"
KEYWORDS="~amd64 ~x86 ~amd64-linux ~x86-linux"
IUSE="+deprecated doc fortran generic ifko lapack static-libs threads"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable fortran and lapack by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

sci-libs/atlas/atlas-3.11.39.ebuild Outdated
}

src_prepare() {
epatch \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use PATCHES=() and drop the whole function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ngg
sci-libs/atlas: version bump to 3.11.39
b9c9cf1 
Patch from upstream is required to build the shared library:
https://sourceforge.net/p/math-atlas/bugs/260/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlec jlec jlec requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ngg @kiwifb @jlec